3085 Commits

Author SHA1 Message Date
ian%hixie.ch
70cff4c514 oops, stray dot meant the private karma scores were getting corrupted! r=kerz
git-svn-id: svn://10.0.0.236/trunk@108866 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-25 01:25:27 +00:00
ian%hixie.ch
05498db6d7 Initial checkin of a karma module. r=kerz b=111757
git-svn-id: svn://10.0.0.236/trunk@108865 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-25 01:01:35 +00:00
ian%hixie.ch
69e9874b10 Changing 'will soon be available as an open source resource' to 'is available as an open source resource'
git-svn-id: svn://10.0.0.236/trunk@108839 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-23 16:50:57 +00:00
ian%hixie.ch
6c5b533a17 work in progress: a component that provides a way for users and admins to edit user preferences, settings, contact details, password, etc.
git-svn-id: svn://10.0.0.236/trunk@108829 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-23 00:16:44 +00:00
ian%hixie.ch
bb6b01bb43 changing the argument names from the cosesEditorXYZ form to the cosesEditor.x.y.z form. This will make them more consistent with how things work elsewhere in PLIF.
git-svn-id: svn://10.0.0.236/trunk@108819 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 20:15:45 +00:00
ian%hixie.ch
90f855808b * Created service- and serviceInstance- specific constructors so that a single module can have distinct constructors depending on how it is invoked. These constructors are called serviceInit() and serviceInstanceInit(), and both chain to the existing init() constructor (so no change are required by this).
* Changed FileStrings so that it doesn't have to be updated every time the file string format changes. The format is now one line per piece of metadata, then a blank line, then the string data. If additional metadata is added later then this will automatically support it.
* Renamed the dataSource.strings service to dataSource.strings.customised, and renamed its get() method to getCustomisedString().
* Changed the semantics of dataSource.strings.customised so that it no longer looks for a default string if it can't find a customised one (and thus removed getDefaultString).
* Abstracted the Generic output module even more. It now consists of output.generic (a service instance with its own constructor) and dataSource.strings (a pure service), the latter of which is a wrapper around dataSource.strings.customised and dataSource.strings.defaults.
* Updated Coses to work with the new dataSource.strings insterface.
* Removed the test app DataSource::ConsoleStrings and DataSource::HTTPStrings files, since they were redundant with the default output files.
* Removed all the default strings in the CosesEditor and Login components since they are pretty pointless.
* Factored out the call to dump() in the GenericOutputs module.
* Changed setString in the MySQL string data source so that it will now add a blank string (it used to delete the string if it was blank, but that meant that it was not possible to customise strings away).
* Added a piece of metadata to strings: their version number.
* Updated the customised string data source stubs to mention the version data now stored with all strings
* Added a getAllStringVersions method to the customised strings data source which returns all the string names and their version numbers.
* Made the customised strings data source check the version number of every string in its database during setupInstall to make sure that they are all up to date, version-wise. If any are out of date, the user is notified.
* Added support for the new version column to the MySQL version of the customised string data source.
* Updated the increasingly misnamed CosesEditor to support the versioned strings stuff.
* Factored out some code in the CosesEditor.
* Added version information to all default strings. All default strings are now at version 1.
* Fixed a typo in a FileStrings dump statement.
* Fixed the calls to setProgress in the MySQL user and strings data sources and in the user field factory to use the correct syntax (a parsable dotted string instead of unlocalisable plain English).
* Updated the Generic output module's documentation to match what now happens.


git-svn-id: svn://10.0.0.236/trunk@108806 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 15:46:42 +00:00
justdave%syndicomm.com
fe649f9b61 Fix for bug 61634: explain what "Milestone URL" is on the editproducts page.
patch by Matthew Tuck <matty@chariot.net.au>
r= caillon, justdave


git-svn-id: svn://10.0.0.236/trunk@108805 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 15:46:27 +00:00
gerv%gerv.net
401144e72a Bug 104261 - incorrect template paths. r=myk, ddk.
git-svn-id: svn://10.0.0.236/trunk@108799 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 06:12:36 +00:00
justdave%syndicomm.com
a159436d81 Fix for bug 99864: consistant use of "product" vs "program"
Patch by Josh Soref <timeless@mac.com>
r= dkl, justdave


git-svn-id: svn://10.0.0.236/trunk@108715 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 19:56:28 +00:00
timeless%mac.com
7560074afe Bugzilla Bug 93754 describe should be #directable
r=justdave,dkl


git-svn-id: svn://10.0.0.236/trunk@108705 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 16:44:38 +00:00
justdave%syndicomm.com
e0e98de5e0 Fix for bug 102141: SECURITY FIX - the Product popup menu on the show_bug form listed all products, even if the user didn't
have access to all of them.  It now only shows products the user has access to (and the product the bug is in, if the user is
viewing it because of some other override)
Patch by George Hotelling <george.hotelling@iconideas.com> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, caillon


git-svn-id: svn://10.0.0.236/trunk@108680 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 08:31:59 +00:00
matty%chariot.net.au
92a2b2029a Bug 110276:SQL error in globals.pl.
Patch by me, r=bbaetz,caillon.


git-svn-id: svn://10.0.0.236/trunk@108678 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 08:09:32 +00:00
barnboy%trilobyte.net
66a77561a4 Added blurb about unified diffs.
git-svn-id: svn://10.0.0.236/trunk@108621 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:16:24 +00:00
barnboy%trilobyte.net
9cd514d2f1 Taint mode note.
git-svn-id: svn://10.0.0.236/trunk@108617 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:11:41 +00:00
barnboy%trilobyte.net
7b8146183a Added Javascript, Cookies, and Templatization requirements to Hacking
Bugzilla.


git-svn-id: svn://10.0.0.236/trunk@108616 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 20:09:06 +00:00
barnboy%trilobyte.net
8c2295b971 Added tip about checking sanitycheck.cgi if you make schema changes,
per bug 98049.


git-svn-id: svn://10.0.0.236/trunk@108613 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 19:56:31 +00:00
barnboy%trilobyte.net
5c12496ebe Removed references to bugzilla.mozilla.org so we can avoid
spurious bug postings.  However, this file will need some significant
treatment for 2.16 release since the query.cgi interface has changed.


git-svn-id: svn://10.0.0.236/trunk@108595 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 18:22:30 +00:00
justdave%syndicomm.com
b1524a2399 Backing out previous checkin, this file is distributed with Bugzilla, we don't need mozilla-specific information in it.
git-svn-id: svn://10.0.0.236/trunk@108594 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 18:11:05 +00:00
barnboy%trilobyte.net
f3a9f9a24c Added one liner mentioning that mozilla.org provides only one vote
per bug.


git-svn-id: svn://10.0.0.236/trunk@108591 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:46:14 +00:00
barnboy%trilobyte.net
93afffd7ff Modified Win32 notes regarding system() calls per bug 99595.
git-svn-id: svn://10.0.0.236/trunk@108590 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:26:45 +00:00
barnboy%trilobyte.net
64144297d3 Fixed CPAN locations per bug 97582.
git-svn-id: svn://10.0.0.236/trunk@108589 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:18:03 +00:00
barnboy%trilobyte.net
a0d50fc6a0 Added bit about needing proper <Directory> permissions in order
for .htaccess to function.  See bug 97668.


git-svn-id: svn://10.0.0.236/trunk@108588 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 17:09:38 +00:00
barnboy%trilobyte.net
aa0ea6b3f9 Changed openjade compilation instructions to match new commands
required by XML conversion of the Guide.


git-svn-id: svn://10.0.0.236/trunk@108586 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 16:41:23 +00:00
barnboy%trilobyte.net
2049c9f6b5 Initial conversion to XML format from SGML.
Note this is a work-in-progress.  It compiles cleanly, but I am not yet
submitting compiled HTML and text.
There is one notable problem: nsgmls barfs on the <imagedata> tag in
database.sgml during validation.  openjade handles it fine. Weird.


git-svn-id: svn://10.0.0.236/trunk@108585 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 16:36:28 +00:00
mcafee%netscape.com
a5f504f183 Removing server-side pageloader data reporting, use client-side scrape mechanism
git-svn-id: svn://10.0.0.236/trunk@108561 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 06:30:18 +00:00
mcafee%netscape.com
cb6752f8c1 Remove server-side data reporting for pageloader test, use client-based scrape mechanism now.
git-svn-id: svn://10.0.0.236/trunk@108560 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 06:27:33 +00:00
mcafee%netscape.com
21f5e9477c bloat.pl not needed, use scrape.pl
git-svn-id: svn://10.0.0.236/trunk@108559 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 05:42:46 +00:00
mcafee%netscape.com
d5acb001b9 Removing old bloat data reporting stuff, use scrape reporting now.
git-svn-id: svn://10.0.0.236/trunk@108557 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 05:27:29 +00:00
mcafee%netscape.com
88bfddd5bb no more startup.dat
git-svn-id: svn://10.0.0.236/trunk@108551 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 03:50:25 +00:00
mcafee%netscape.com
518aa115bf startup.pl should use scrape.pl mechanism now.
git-svn-id: svn://10.0.0.236/trunk@108550 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 03:47:05 +00:00
mcafee%netscape.com
74f0dd9e37 startup data goes to scrapt.dat now.
git-svn-id: svn://10.0.0.236/trunk@108549 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 03:43:27 +00:00
myk%mozilla.org
cb97f8190d Fix for bug 109240: fixes the regression that changed the way comments regarding attachment creation are formatted.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@108542 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 02:59:55 +00:00
zach%zachlipton.com
a8d489f851 Fix for bug 107120, templates/default/global/header has invalid HTML.
Patch removes a <meta> tag as per bug 38856.

Patch by David D. Kilzer <mailto:ddkilzer@theracingworld.com>.
r1=Christopher Aillon <mailto:caillon@returnzero.com>. No 2nd review
required as per caillon.


git-svn-id: svn://10.0.0.236/trunk@108525 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 01:59:57 +00:00
gerv%gerv.net
f2a3c7158a Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108457 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:23:31 +00:00
gerv%gerv.net
34838abe95 Bug 98707. Query.cgi rewrite, reformatting and templatisation. Patch by me, layout by mpt and others, r=justdave,matty. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108455 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:20:20 +00:00
matty%chariot.net.au
ca6d7f14fc Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".

The patch was by James A Laska <jlaska@us.ibm.com>.


git-svn-id: svn://10.0.0.236/trunk@108420 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:54:54 +00:00
matty%chariot.net.au
067fbac069 *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@108419 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:22:50 +00:00
justdave%syndicomm.com
bfa6922bde Fix for bug 100788: enter_bug.cgi wasn't correctly interpretting whether or not a partial URL needed an http:// added to the
front of it, which had the side-effect of duplicating the http:// on the front when a URL was passed from Bugzilla Helper.
Patch by Josh Soref <timeless@mac.com>
r= justdave, caillon


git-svn-id: svn://10.0.0.236/trunk@108404 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 23:05:48 +00:00
justdave%syndicomm.com
f7a62b41f9 Fix for bug 109354: After entering a new bug, the link offering to add an attachment to the bug you just created pointed at
the old attachment form instead of the new one.
Patch by Josh Soref <timeless@mac.com>
r= myk x2


git-svn-id: svn://10.0.0.236/trunk@108402 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:40:02 +00:00
justdave%syndicomm.com
b696d2648c Fix for bug 107120: templates/default/global/header was generating HTML that wouldn't validate as HTML 4.01 Transitional
Patch by Dave Miller <justdave@syndicomm.com>
r= jake, bbaetz


git-svn-id: svn://10.0.0.236/trunk@108401 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:25:15 +00:00
justdave%syndicomm.com
1a5671d3ab Fix for bug 92500: line-feeds were not being properly converted when submitting parameter changes with some Mac browsers.
Patch by Gervase Markham <gerv@mozilla.org>
r= ddk, justdave


git-svn-id: svn://10.0.0.236/trunk@108399 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:18:07 +00:00
justdave%syndicomm.com
ab0ed93ca8 Backing out previous checkin, it broke the tree. :(
git-svn-id: svn://10.0.0.236/trunk@108396 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
2f07aa0c10 Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk


git-svn-id: svn://10.0.0.236/trunk@108394 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:12:53 +00:00
justdave%syndicomm.com
38ae4f7251 Fix for bug 12284: allow user to specify which columns to display in a bug list
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= gerv, kiko


git-svn-id: svn://10.0.0.236/trunk@108392 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:04:37 +00:00
ian%hixie.ch
8c8be7f871 Correct some XML errors in the default output strings.
git-svn-id: svn://10.0.0.236/trunk@108391 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 20:57:42 +00:00
zach%zachlipton.com
0d8c3fd7a1 Fix the double testing of .pm files.
No review needed for tests at this time.


git-svn-id: svn://10.0.0.236/trunk@108382 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 17:29:06 +00:00
matty%chariot.net.au
2ddf8be3ca Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
Patch by Christoper Aillon <caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@108373 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 10:29:55 +00:00
bbaetz%cs.mcgill.ca
eb246d5306 Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
Quote manually rather than using qw to get arround this


git-svn-id: svn://10.0.0.236/trunk@108365 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:57:25 +00:00
bbaetz%cs.mcgill.ca
3bc2957b7a Bug 101560 - clear some more env vars so that system calls will run in
taint mode. The perforce integration stuff needs this.

r=gerv,mattyt


git-svn-id: svn://10.0.0.236/trunk@108362 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:19:46 +00:00
mcafee%netscape.com
0a10a3bc8b removing server-side startup data reporting, use client-side TinderboxPrint: now.
git-svn-id: svn://10.0.0.236/trunk@108361 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 06:52:50 +00:00