63 Commits

Author SHA1 Message Date
lpsolit%gmail.com
f9d60a3911 Bug 323955: Deleting a group incorrectly checks for user group membership (miss group inheritance) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@187966 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-21 13:48:56 +00:00
lpsolit%gmail.com
989ff8404a Bug 299646: Potential missing entries in bug_group_map related to mandatory groups - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@186739 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-30 00:54:25 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
5b12f6bedc Bug 306271: Group.pm needs a get_all_groups() routine - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=myk
git-svn-id: svn://10.0.0.236/trunk@179312 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 16:39:07 +00:00
lpsolit%gmail.com
134b186c2c Bug 303704: Eliminate deprecated Bugzilla::DB routines from editgroups.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@179084 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 19:46:27 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
065ad45230 Bug 303141: Missing buglist when deleting groups - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177044 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-03 00:38:35 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
mkanat%kerio.com
02aa35925a Bug 287138: INSERT IGNORE is not ANSI SQL
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170976 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-22 09:01:22 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
erik%dasbistro.com
670b6254a0 Bug 253721: Add group-based lists to whining
Patch by Erik Stambaugh <erik@dasbistro.com>
r=joel, r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169438 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 22:42:07 +00:00
bugzilla%glob.com.au
3ff37133f6 Bug 282510: Argument "" isn't numeric when modifying group
Patch by Byron Jones <bugzilla@glob.com.au> r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169393 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:38:42 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
a5e2487330 Bug 277768 : Some validations are missing when editing groups
Patch by Frederic Buclin <LpSolit@gmail.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169254 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:26:43 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
jocuri%softhome.net
9b7827dd9b Patch for bug 180879: Implement privs for bug flags modification; patch by Frédéric Buclin <LpSolit@netscape.net>, r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@165677 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-23 22:41:44 +00:00
bugreport%peshkin.net
12e5e8c5f9 Bug 244239: Add group-based pronouns to query
r=erik,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160666 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-11 14:00:34 +00:00
jocuri%softhome.net
23204eca2d Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 09:36:18 +00:00
bugreport%peshkin.net
1b0c07d9df Bug 251837: Extend group_group_map to control which groups can see each other
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159914 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 16:33:41 +00:00
jocuri%softhome.net
70284e3089 Patch for bug 190222: templatize editgroups.cgi; r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@159122 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:12:33 +00:00
bugreport%peshkin.net
4c42de310e Bug 250080: Fix regression causing blank regexp to make all users group members
r=erik, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158826 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 05:10:55 +00:00
jocuri%softhome.net
227f7186fb Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158711 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-03 00:26:29 +00:00
bugreport%peshkin.net
5fe78bc59c Bug 240325: Keep regexp-based groups up-to-date
git-svn-id: svn://10.0.0.236/trunk@157940 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-16 05:04:48 +00:00
jouni%heikniemi.net
6a3903cfce Bug 208847: Fix taint issues in editgroups.cgi
Patch by byron jones <bugzilla@glob.com.au>,
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156793 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:07:50 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
bugreport%peshkin.net
86bcf7c2ba Bug 181589: Add mass-remove to editgroups
r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@154304 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 15:18:07 +00:00
jouni%heikniemi.net
1f02d8657e Bug 226119: The template admin/add-group.html.tmpl moved to admin/groups/create.html.tmpl to better match with admin template naming consensus discussed in reviewers@.
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@149544 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-19 06:42:09 +00:00
caillon%returnzero.com
ea63ffa0e7 226061 - someone forgot to tell editgroups that regexps are applied at runtime, not on account creation.
r=joel,a=justdave


git-svn-id: svn://10.0.0.236/trunk@149501 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-18 18:55:44 +00:00
jocuri%softhome.net
9aa27336fa Bug 207211: Editgroups.cgi - template for add a group page; r=myk; a=myk.
git-svn-id: svn://10.0.0.236/trunk@149075 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-09 21:07:26 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
zach%zachlipton.com
70edadec69 Fix for bug 166481 ("Spellcheck is borked"). Part one of this fix fixes
the spelling errors so tinderbox doesn't barf, part two fixes
t/006spellcheck.t and adds some more new words to check for.

Part 1 patch by myself, r=timeless
Part 2 patch by MattyT. r=zach (myself)
a=justdave


git-svn-id: svn://10.0.0.236/trunk@136179 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-10 23:51:38 +00:00
bugreport%peshkin.net
1c221514d7 Bug 181951 Cannot delete groups
Patch by joel
r=burnus,bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134591 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-30 03:46:03 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-24 19:56:34 +00:00
bugreport%peshkin.net
050fe637e1 Bug 171440 editgroups shows system groups as usable for bugs even though they are not
2xr=justdave


git-svn-id: svn://10.0.0.236/trunk@130691 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 22:54:44 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
jake%bugzilla.org
b7a53c11ec Updating my e-mail address as jake@acutex.net is no longer valid.
* NO CODE CHANGES *


git-svn-id: svn://10.0.0.236/trunk@128230 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-27 04:28:05 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00