Thanks go to Andrew Wason <aw@softcom.com> for finding this problem and providing the patch:
If we implement a Java interface in JavaScript, and a method in that interface returns a Java object, we get a java.lang.IncompatibleClassChangeError: org/mozilla/javascript/Wrapper exception.
We have attached a sample JavaScript file which duplicates the error.
The problem is JavaAdapter is generating an INVOKEVIRTUAL bytecode to call Wrapper.unwrap, but Wrapper is an interface and so INVOKEINTERFACE should be used instead. As a result of this change, the IFEQ bytecode generated needs to jump more bytes. We have attached a patch that fixes the problem.
Andrew
--
Andrew Wason
SoftCom, Inc.
aw@softcom.com
git-svn-id: svn://10.0.0.236/trunk@41131 18797224-902f-48f8-a5cc-f745e15eee43
- normalized initial MPL comment to match the format of others in the tree, including an initial -*- Mode line.
- removed RCS $log$, etc. comments. We use CVS, and they just make spurious changes...
git-svn-id: svn://10.0.0.236/trunk@41129 18797224-902f-48f8-a5cc-f745e15eee43
- js_DecompileValueGenerator had rusted due to bytecode/source-note changes,
or maybe parts of it never worked right. Anyway, it now does not induce a
crashing underflow in the decompiler. As part of this fix, it now takes a
checkStack flag telling whether to look for the jsval v argument on the JS
stack. The calls from ImportProperty, js_SetProperty, and js_DeleteProperty
pass in v a jsval for the property id, which should not be sought after on
the stack (it might happen to be there due to o['p'] = 2, but we want to
decompile o["p"], not "p").
- js_DecompileValueGenerator would load a generating pc even if the value v
did not match the pc's corresponding stack item! Oops. This lead to less
than idea diagnostics.
- js_DecompileValueGenerator was also not mapping JSOP_TRAP to the real op at
a sufficiently early and univeral point in its control flow.
- Fix PopOff to assert and check for stack underflow in the decompiler, and
beef up PushOff too (it asserted, but did not check).
- js_ReportIsNotFunction now avoids JS_InternString by indexing directly into
cx->runtime->atomState.typeAtoms with the result of JS_TypeOfValue.
- Removed unnecessary local GC root reserved by non-zero trailing member of
obj_eval's JSFunctionSpec initializer.
git-svn-id: svn://10.0.0.236/trunk@40864 18797224-902f-48f8-a5cc-f745e15eee43
Patches courtesy bob meader <bob@guiduck.com> who seems to be working fast and furious on this port.
git-svn-id: svn://10.0.0.236/trunk@40594 18797224-902f-48f8-a5cc-f745e15eee43
this is not part of the mozilla client build, and has no effect on its
bustedness.
git-svn-id: svn://10.0.0.236/trunk@40292 18797224-902f-48f8-a5cc-f745e15eee43
fix regression test for #7703.
This is not part of the mozilla build and has no effect on its bustedness.
git-svn-id: svn://10.0.0.236/trunk@39761 18797224-902f-48f8-a5cc-f745e15eee43
This is not part of the mozilla build and has no effect on its bustedness.
git-svn-id: svn://10.0.0.236/trunk@39616 18797224-902f-48f8-a5cc-f745e15eee43
This is not part of the mozilla build and has no effect on build bustage.
git-svn-id: svn://10.0.0.236/trunk@39613 18797224-902f-48f8-a5cc-f745e15eee43
Thanks go to Martin Honnen <martin.honnen@sector27.de> for spotting this difference from the spec.
git-svn-id: svn://10.0.0.236/trunk@39607 18797224-902f-48f8-a5cc-f745e15eee43
Add an #if defined(__arm) check to tell jsdtoa.c about the (somewhat bizzare) endian-ness of the ARM architecture.
Thanks go to Stefan Hanske <sh990154@mail.uni-greifswald.de> for this fix.
git-svn-id: svn://10.0.0.236/trunk@39604 18797224-902f-48f8-a5cc-f745e15eee43
2) rooted out all instances of JS_ReportErros and replaced with JS exception throwing.
3) added more exception message types.
4) Added service (also reflected into JS) for getting JS and native stack objects to be used in exceptions.
5) Fixed broken test.
6) updated TODO list.
git-svn-id: svn://10.0.0.236/trunk@39511 18797224-902f-48f8-a5cc-f745e15eee43
to define an unbound global variable used to enumerate an empty object, when
the standard says no variable should be defined.
- Clean up minor nits, make comment style match prevailing, tighten up for..in
element-indexing special case comments.
- Fix js_Invoke to take CONSTRUCT and INTERNAL flags arg instead of a construct
boolean arg and the JSStackFrame internalCall mis-located boolean non-arg.
Use these flags correctly in all calls (previous version failed to set the
bogus frame.internalCall around js_Invoke calls from jsfun.c and jsstr.c).
git-svn-id: svn://10.0.0.236/trunk@39473 18797224-902f-48f8-a5cc-f745e15eee43
