117 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
9d1b4759b5 Bug 339750: Remove Bugzilla::Flag::GetBug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@200249 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-18 22:46:50 +00:00
lpsolit%gmail.com
279ec88e97 Bug 340116: Flag::FormToNewFlags() uses incorrect data - Patch by Frédéric Buclin <LpSolit@gmail.com> r=kiko a=myk
git-svn-id: svn://10.0.0.236/trunk@198920 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 23:02:52 +00:00
lpsolit%gmail.com
d9dd48a759 Bug 339862: Move Bugzilla::BugMail::MessageToMTA() in a separate module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@198863 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-02 10:50:15 +00:00
lpsolit%gmail.com
80e7a0ca5b Bug 300549: Eliminate deprecated Bugzilla::DB routines from Flag.pm and FlagType.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@196710 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 22:49:14 +00:00
lpsolit%gmail.com
9069ef91fc Bug 332521: Remove GroupIdToName() from globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@196143 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-07 19:56:05 +00:00
lpsolit%gmail.com
b440b8e903 Bug 322285: Cancelling a flag should remove it completely from the DB - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@194416 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-14 16:50:47 +00:00
lpsolit%gmail.com
d096e3af79 Bug 331343: The timestamp is quoted twice in Bugzilla::Flag::modify() - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@193563 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 21:55:37 +00:00
lpsolit%gmail.com
f612db1f4f Bug 284590: When using SMTP, emails are not sent to the CC list associated with the flag type - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@186737 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-30 00:32:37 +00:00
lpsolit%gmail.com
31421e8ef2 Bug 266147: Internal error when Flag::notify() ends up with an invalid or empty CC: list and no requestee in restricted bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@186017 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-13 21:16:16 +00:00
lpsolit%gmail.com
64f1a95f02 Bug 304075: Eliminate use of $::userid from Bugzilla - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@183259 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-30 21:31:29 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
897bd45d39 Bug 302936: Reject the requestee if he cannot access private attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=jouni a=justdave
git-svn-id: svn://10.0.0.236/trunk@182466 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-18 17:48:08 +00:00
lpsolit%gmail.com
56985e1098 Bug 304745: Move GetFieldID() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@179668 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-05 20:41:21 +00:00
myk%mozilla.org
ff7b44d6d9 Partial fix for bug 302669: rewrites Attachment.pm to provide a real Attachment class; r=lpsolit
git-svn-id: svn://10.0.0.236/trunk@179468 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 14:02:30 +00:00
myk%mozilla.org
c33c7df18b Fix for bug 305773: fixes regression in flag validation code that let through untrusted requestees when multiple requestees were entered into a requestee field (per the new feature that lets multiple requestees be entered into those fields); r=lpsolit
git-svn-id: svn://10.0.0.236/trunk@179346 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 22:41:18 +00:00
lpsolit%gmail.com
902fd7136c Bug 305771: Cannot create request flags with no requestee - Patch by Myk Melez <myk@mozilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179040 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 10:53:23 +00:00
myk%mozilla.org
60325570ad Fix for bug 292022: accepts multiple requestees in the requestee field for a given flag, and creates multiple requests, one per requestee, so that users can request a flag multiple times simultaneously instead of one at a time; r=joel, a=myk
git-svn-id: svn://10.0.0.236/trunk@178515 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-20 17:02:41 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
lpsolit%gmail.com
12f4168465 Bug 304642: Bugzilla::Flag::GetTarget() should be called internally by Bugzilla::Flag::process() - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@177769 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 18:48:14 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
4fe5766722 Bug 301967: Some .pm files have invalid POD syntax - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@176610 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 14:09:48 +00:00
mkanat%kerio.com
60e6184230 Bug 293159: [SECURITY] Anyone can change flags and access bug summaries due to a bad check in Flag::validate() and Flag::modify()
Patch By Frederic Buclin <LpSolit@gmail.com> r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175823 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 05:30:59 +00:00
lpsolit%gmail.com
abe1fde58b Bug 299211: whine.pl fails if derive_groups is required - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@175771 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 18:33:46 +00:00
mkanat%kerio.com
561bb9c551 Bug 289042: Implicit joins should be replaced by explicit joins - installment B
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175517 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-02 05:23:28 +00:00
lpsolit%gmail.com
f28fb03f79 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174889 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:46:39 +00:00
lpsolit%gmail.com
66a6bcfa70 Backing out bug 180792. A table is locked as READ while my patch tries to write in it :(
git-svn-id: svn://10.0.0.236/trunk@174886 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:20:50 +00:00
lpsolit%gmail.com
2725687439 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174871 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 20:04:24 +00:00
lpsolit%gmail.com
54dd559703 Bug 266159: It's possible to create multiple flags by reloading, even if flag is not multiplicable - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a = myk
git-svn-id: svn://10.0.0.236/trunk@174444 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-10 22:57:16 +00:00
myk%mozilla.org
d6312ffd28 Fix for bug 291391: allows users to rerequest set flags even if they don't have the privilege to set them; r=lpsolit; a=myk
git-svn-id: svn://10.0.0.236/trunk@172591 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-22 02:17:14 +00:00
lpsolit%gmail.com
ac7034f6cb Bug 288603: Allow users in the request group to remove pending requests made by others - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@172444 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 18:11:41 +00:00
lpsolit%gmail.com
f3f72e2a0d Bug 289729: fix several "uninitialized value" messages - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@172043 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 20:21:45 +00:00
lpsolit%gmail.com
6d78cc1d1b Bug 238878: Make hidden-fields template, User Matching and Flags use direct CGI instead of [% form.foo %] - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:37:56 +00:00
gerv%gerv.net
7b09ffbc80 Bug 73665 - migrate email preferences to their own table, and rearchitect email internals. Patch by gerv; r=jake, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@171337 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-29 21:43:00 +00:00
mkanat%kerio.com
b7883c6ae6 Bug 283230: POD for Bugzilla::Flag
Patch By Kevin Benton <kevin.benton@amd.com> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@170767 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 02:39:08 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
d2223e28fc Fix nits on bug 180652 - Frederic Buclin
git-svn-id: svn://10.0.0.236/trunk@170732 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:08:12 +00:00
travis%sedsystems.ca
d21f70cb83 Bug 180652 : Marking an attachment as obsolete should cancel all unfulfilled requests
Patch by Frederic Buclin <LpSolit@gmail.com>  r=myk  a=myk


git-svn-id: svn://10.0.0.236/trunk@170705 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 15:57:19 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
jocuri%softhome.net
d11f7f6055 Patch for bug 277622: Move DiffStrings() out of globals.pl into Bugzilla/Util.pm; patch by Max K-A <mkanat@kerio.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167812 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:02:35 +00:00
jocuri%softhome.net
28b0d85158 Patch for bug 277389: Modify flag notification code so it doesn't append emailsuffix to CC list's addresses; patch by Marc Schumann <wurblzap@gmail.com>, r=wurblzap, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167422 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-08 18:35:23 +00:00
gerv%gerv.net
8606b2d55d Bug 59351 - move all calls to sendmail to a central place. Patch by mkanat; r=gerv,vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167149 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-01 13:47:56 +00:00
jocuri%softhome.net
bd4425469a Patch for bug 276283: Users should be able to cancel their own flag requests; patch by me, r=LpSolit (Frederic), a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167138 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-31 10:45:57 +00:00
jocuri%softhome.net
490e0c4ac6 Patch for bug 273339: Make attachment.cgi consistent with its activity log timestamps; patch by GavinS <bugzilla@chimpychompy.org>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167073 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-28 23:39:05 +00:00
jocuri%softhome.net
9b7827dd9b Patch for bug 180879: Implement privs for bug flags modification; patch by Frédéric Buclin <LpSolit@netscape.net>, r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@165677 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-23 22:41:44 +00:00
jocuri%softhome.net
9d1ec8d20e Patch for bug 212017: Should be able to change a bug if it has a flag requested that is no longer requestable; patch by Frédéric Buclin <LpSolit@netscape.net>; r=myk, vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@164810 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-02 22:59:40 +00:00
jocuri%softhome.net
a7f61577a1 Bug 256762: make flag request email use emailsuffix; patch by Marc Schumann <wurblzap@gmail.com>; r=kiko; a=myk.
git-svn-id: svn://10.0.0.236/trunk@161691 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-03 06:51:07 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
bugreport%peshkin.net
9b86bfce63 Bug 250967: Fix spurious updates to requesteeless flags
patch by jouni
r=kiko,joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159165 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-14 02:40:21 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00