bzrmirror%bugzilla.org
3e500ddd23
Bug 1075578: [SECURITY] Improper filtering of CGI arguments
...
r=dkl,a=sgreen
git-svn-id: svn://10.0.0.236/branches/BUGZILLA-4_0-BRANCH@265600 18797224-902f-48f8-a5cc-f745e15eee43
2014-10-06 14:31:49 +00:00
mkanat%bugzilla.org
ecf0f13ce8
Bug 565879: Merge ThrowCodeError("action_unrecognized"), ThrowUserError("no_valid_action") and ThrowCodeError("unknown_action")
...
r=ghendricks a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@260347 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-20 15:46:29 +00:00
mkanat%bugzilla.org
0c4b8ff3b5
Bug 520318: Add remove_from_db to Bugzilla:Group and use it to delete groups in editgroups.cgi
...
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@259325 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:48:23 +00:00
mkanat%bugzilla.org
3178e0cbf0
Bug 511796: Allow groups to bless themselves
...
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@258533 18797224-902f-48f8-a5cc-f745e15eee43
2009-09-30 08:59:50 +00:00
lpsolit%gmail.com
bfda31bbd9
Bug 478972: Remove the 'useentrygroupdefault' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
...
git-svn-id: svn://10.0.0.236/trunk@256770 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-31 19:17:03 +00:00
lpsolit%gmail.com
ef74a28932
Bug 405355: Move flatten_group_membership() from User.pm to Group.pm - Patch by arbingersys <arbingersys@gmail.com> r/a=LpSolit
...
git-svn-id: svn://10.0.0.236/trunk@255919 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-25 18:49:31 +00:00
mkanat%bugzilla.org
908ea11d7f
Bug 460581: editgroups should be using Bugzilla::Group->create to make groups
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@254653 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-18 16:15:21 +00:00
lpsolit%gmail.com
262b269991
Bug 325487: Admin pages should require less "clicks" (remove useless confirmation pages) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=justdave r=mkanat a=LpSolit
...
git-svn-id: svn://10.0.0.236/trunk@244165 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-27 23:14:26 +00:00
mkanat%bugzilla.org
d7e641858a
Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
lpsolit%gmail.com
55fed2d7ff
Bug 398976: edit*.cgi scripts should use transactions for database interaction - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat
...
git-svn-id: svn://10.0.0.236/trunk@237494 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-09 23:21:49 +00:00
mkanat%bugzilla.org
e0543820c9
Bug 398883: [mod_perl] Three Variable "$cgi" will not stay shared errors in current CVS HEAD
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237386 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-07 21:32:23 +00:00
lpsolit%gmail.com
3303087194
Bug 332149: Ability to have symbols placed next to user names based on group membership - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=LpSolit
...
git-svn-id: svn://10.0.0.236/trunk@231653 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-08 14:04:20 +00:00
mkanat%bugzilla.org
d118f53d94
Bug 354627: Improve the UI for adding/removing inheritance in editgroups.cgi
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org r=LpSolit, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@221368 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-06 04:54:07 +00:00
lpsolit%gmail.com
0790403f09
Bug 349855: editgroups.cgi doesn't protect the querysharegroup from deletion
...
Bug 357429: Renaming a group which plays a special role generates a SQL error
Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@213935 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-20 21:16:53 +00:00
lpsolit%gmail.com
58b1b66792
Bug 281181: [SECURITY] It's way too easy to delete versions/components/milestones etc... - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@213652 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-14 22:02:10 +00:00
mkanat%bugzilla.org
2fcef33cc7
Bug 346597: Have Bugzilla::Group implement Bugzilla::Object->create, and make checksetup.pl use it
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk
git-svn-id: svn://10.0.0.236/trunk@210088 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-14 00:33:41 +00:00
mkanat%bugzilla.org
bff299a118
Bug 339383: Make Bugzilla::Group use Bugzilla::Object
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bkor, a=myk
git-svn-id: svn://10.0.0.236/trunk@206775 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 23:05:00 +00:00
lpsolit%gmail.com
986ce57313
Bug 305941: Remove profiles.refreshed_when and groups.last_changed - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@206625 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-04 22:24:48 +00:00
mkanat%bugzilla.org
64680b25b1
Bug 346483: Fix up param-updating code in checksetup.pl to all be in a module.
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=myk
git-svn-id: svn://10.0.0.236/trunk@206222 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-31 22:15:55 +00:00
wurblzap%gmail.com
adc3fc4f09
Bug 69000: Permit a stored query to be marked "shared" and accessible by other users.
...
Patch by Marc Schumann <wurblzap@gmail.com>,
r=vladd, a=myk
git-svn-id: svn://10.0.0.236/trunk@202073 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-13 20:08:00 +00:00
mkanat%bugzilla.org
520fe42625
Bug 338375: Use Bugzilla->params everywhere instead of Param().
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40
Bug 342869: Use Bugzilla->params everywhere except templates
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659
Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
vladd%bugzilla.org
e68e2fc370
Spelling patch: use the right spelling form for 'explicitly'; patch by Vlad Dascalu <vladd@bugzilla.org>.
...
git-svn-id: svn://10.0.0.236/trunk@200317 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 16:44:00 +00:00
lpsolit%gmail.com
eba2e330c1
Bug 338796: Remove get_product_* from globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@200219 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-17 23:12:36 +00:00
lpsolit%gmail.com
495711e640
Bug 324784: editgroups.cgi should make sure groups it edits/removes are not used by editparams.cgi (in data/params) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@198582 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-29 18:11:04 +00:00
lpsolit%gmail.com
968cee22b7
Bug 301020: Remove useless locked tables - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@193321 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 10:27:26 +00:00
lpsolit%gmail.com
7844d8c13a
Bug 329022: Remove group_name_to_id in favor of creating Group objects - Patch by Rémi Zara <remi_zara@mac.com> r=LpSolit a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@192365 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 22:47:24 +00:00
lpsolit%gmail.com
2423c172b0
Bug 323912: When a group cannot be deleted because it is in used, ThrowUserError() should be called - Patch by Frédéric Buclin <LpSolit@gmail.com> r=GavinS a=myk
...
git-svn-id: svn://10.0.0.236/trunk@192029 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-08 23:53:57 +00:00
mkanat%kerio.com
b480f31d72
Bug 328435: Move GroupNameToId into Bugzilla/Group.pm and eliminate GroupExists
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wicked, a=justdave
git-svn-id: svn://10.0.0.236/trunk@191523 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-01 21:33:01 +00:00
lpsolit%gmail.com
a1bd0f3faa
Bug 324248: Deleting a group doesn't remove entries in group_group_map correctly - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@188011 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-22 20:12:20 +00:00
lpsolit%gmail.com
f9d60a3911
Bug 323955: Deleting a group incorrectly checks for user group membership (miss group inheritance) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@187966 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-21 13:48:56 +00:00
lpsolit%gmail.com
989ff8404a
Bug 299646: Potential missing entries in bug_group_map related to mandatory groups - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@186739 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-30 00:54:25 +00:00
lpsolit%gmail.com
e334b85a95
Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
529ea73dda
Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
5b12f6bedc
Bug 306271: Group.pm needs a get_all_groups() routine - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=myk
...
git-svn-id: svn://10.0.0.236/trunk@179312 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 16:39:07 +00:00
lpsolit%gmail.com
134b186c2c
Bug 303704: Eliminate deprecated Bugzilla::DB routines from editgroups.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@179084 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 19:46:27 +00:00
bugreport%peshkin.net
205c3f3402
Bug 304583: Remove all remaining need to rederive inherited groups
...
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave
git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
mkanat%kerio.com
0cbbdcfee7
Bug 303669: Bugzilla mis-uses perl subroutine prototypes
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746
Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8
Backout of bug 303669 which broke AppendComment and possibly a number
...
of other items.
git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3
Bug 303669: Bugzilla mis-uses perl subroutine prototypes
...
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
065ad45230
Bug 303141: Missing buglist when deleting groups - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@177044 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-03 00:38:35 +00:00
mkanat%kerio.com
833b2e61f6
Bug 286235: Implicit joins should be replaced by explicit joins - installment A
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk
git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
mkanat%kerio.com
02aa35925a
Bug 287138: INSERT IGNORE is not ANSI SQL
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave
git-svn-id: svn://10.0.0.236/trunk@170976 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-22 09:01:22 +00:00
travis%sedsystems.ca
7351a5b76b
Bug 283581 : Move UserInGroup out of globals.pl
...
Patch by Colin Ogilvie <colin.ogilvie@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
erik%dasbistro.com
670b6254a0
Bug 253721: Add group-based lists to whining
...
Patch by Erik Stambaugh <erik@dasbistro.com>
r=joel, r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@169438 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 22:42:07 +00:00
bugzilla%glob.com.au
3ff37133f6
Bug 282510: Argument "" isn't numeric when modifying group
...
Patch by Byron Jones <bugzilla@glob.com.au> r,a=justdave
git-svn-id: svn://10.0.0.236/trunk@169393 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:38:42 +00:00
mkanat%kerio.com
c8f7e44c64
Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave
git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
a88c76e484
Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk
git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00