53 Commits

Author SHA1 Message Date
myk%mozilla.org
ff7b44d6d9 Partial fix for bug 302669: rewrites Attachment.pm to provide a real Attachment class; r=lpsolit
git-svn-id: svn://10.0.0.236/trunk@179468 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 14:02:30 +00:00
myk%mozilla.org
c33c7df18b Fix for bug 305773: fixes regression in flag validation code that let through untrusted requestees when multiple requestees were entered into a requestee field (per the new feature that lets multiple requestees be entered into those fields); r=lpsolit
git-svn-id: svn://10.0.0.236/trunk@179346 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 22:41:18 +00:00
lpsolit%gmail.com
902fd7136c Bug 305771: Cannot create request flags with no requestee - Patch by Myk Melez <myk@mozilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179040 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 10:53:23 +00:00
myk%mozilla.org
60325570ad Fix for bug 292022: accepts multiple requestees in the requestee field for a given flag, and creates multiple requests, one per requestee, so that users can request a flag multiple times simultaneously instead of one at a time; r=joel, a=myk
git-svn-id: svn://10.0.0.236/trunk@178515 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-20 17:02:41 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
lpsolit%gmail.com
12f4168465 Bug 304642: Bugzilla::Flag::GetTarget() should be called internally by Bugzilla::Flag::process() - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@177769 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 18:48:14 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
4fe5766722 Bug 301967: Some .pm files have invalid POD syntax - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@176610 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 14:09:48 +00:00
mkanat%kerio.com
60e6184230 Bug 293159: [SECURITY] Anyone can change flags and access bug summaries due to a bad check in Flag::validate() and Flag::modify()
Patch By Frederic Buclin <LpSolit@gmail.com> r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175823 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 05:30:59 +00:00
lpsolit%gmail.com
abe1fde58b Bug 299211: whine.pl fails if derive_groups is required - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@175771 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 18:33:46 +00:00
mkanat%kerio.com
561bb9c551 Bug 289042: Implicit joins should be replaced by explicit joins - installment B
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175517 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-02 05:23:28 +00:00
lpsolit%gmail.com
f28fb03f79 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174889 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:46:39 +00:00
lpsolit%gmail.com
66a6bcfa70 Backing out bug 180792. A table is locked as READ while my patch tries to write in it :(
git-svn-id: svn://10.0.0.236/trunk@174886 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:20:50 +00:00
lpsolit%gmail.com
2725687439 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174871 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 20:04:24 +00:00
lpsolit%gmail.com
54dd559703 Bug 266159: It's possible to create multiple flags by reloading, even if flag is not multiplicable - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a = myk
git-svn-id: svn://10.0.0.236/trunk@174444 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-10 22:57:16 +00:00
myk%mozilla.org
d6312ffd28 Fix for bug 291391: allows users to rerequest set flags even if they don't have the privilege to set them; r=lpsolit; a=myk
git-svn-id: svn://10.0.0.236/trunk@172591 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-22 02:17:14 +00:00
lpsolit%gmail.com
ac7034f6cb Bug 288603: Allow users in the request group to remove pending requests made by others - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@172444 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 18:11:41 +00:00
lpsolit%gmail.com
f3f72e2a0d Bug 289729: fix several "uninitialized value" messages - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@172043 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 20:21:45 +00:00
lpsolit%gmail.com
6d78cc1d1b Bug 238878: Make hidden-fields template, User Matching and Flags use direct CGI instead of [% form.foo %] - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:37:56 +00:00
gerv%gerv.net
7b09ffbc80 Bug 73665 - migrate email preferences to their own table, and rearchitect email internals. Patch by gerv; r=jake, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@171337 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-29 21:43:00 +00:00
mkanat%kerio.com
b7883c6ae6 Bug 283230: POD for Bugzilla::Flag
Patch By Kevin Benton <kevin.benton@amd.com> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@170767 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 02:39:08 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
d2223e28fc Fix nits on bug 180652 - Frederic Buclin
git-svn-id: svn://10.0.0.236/trunk@170732 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:08:12 +00:00
travis%sedsystems.ca
d21f70cb83 Bug 180652 : Marking an attachment as obsolete should cancel all unfulfilled requests
Patch by Frederic Buclin <LpSolit@gmail.com>  r=myk  a=myk


git-svn-id: svn://10.0.0.236/trunk@170705 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 15:57:19 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
jocuri%softhome.net
d11f7f6055 Patch for bug 277622: Move DiffStrings() out of globals.pl into Bugzilla/Util.pm; patch by Max K-A <mkanat@kerio.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167812 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:02:35 +00:00
jocuri%softhome.net
28b0d85158 Patch for bug 277389: Modify flag notification code so it doesn't append emailsuffix to CC list's addresses; patch by Marc Schumann <wurblzap@gmail.com>, r=wurblzap, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167422 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-08 18:35:23 +00:00
gerv%gerv.net
8606b2d55d Bug 59351 - move all calls to sendmail to a central place. Patch by mkanat; r=gerv,vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167149 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-01 13:47:56 +00:00
jocuri%softhome.net
bd4425469a Patch for bug 276283: Users should be able to cancel their own flag requests; patch by me, r=LpSolit (Frederic), a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167138 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-31 10:45:57 +00:00
jocuri%softhome.net
490e0c4ac6 Patch for bug 273339: Make attachment.cgi consistent with its activity log timestamps; patch by GavinS <bugzilla@chimpychompy.org>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167073 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-28 23:39:05 +00:00
jocuri%softhome.net
9b7827dd9b Patch for bug 180879: Implement privs for bug flags modification; patch by Frédéric Buclin <LpSolit@netscape.net>, r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@165677 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-23 22:41:44 +00:00
jocuri%softhome.net
9d1ec8d20e Patch for bug 212017: Should be able to change a bug if it has a flag requested that is no longer requestable; patch by Frédéric Buclin <LpSolit@netscape.net>; r=myk, vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@164810 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-02 22:59:40 +00:00
jocuri%softhome.net
a7f61577a1 Bug 256762: make flag request email use emailsuffix; patch by Marc Schumann <wurblzap@gmail.com>; r=kiko; a=myk.
git-svn-id: svn://10.0.0.236/trunk@161691 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-03 06:51:07 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
bugreport%peshkin.net
9b86bfce63 Bug 250967: Fix spurious updates to requesteeless flags
patch by jouni
r=kiko,joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159165 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-14 02:40:21 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00
jocuri%softhome.net
966983881d Patch for bug 232554: fix SQL queries in Flag.pm in order to fix a bug that causes flags to remain set but inaccessible when product changes; patch by Max K-A <mkanat@kerio.com>; r=bbaetz,myk; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154426 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-01 08:57:59 +00:00
justdave%syndicomm.com
e099454c93 Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now.
r= myk, gerv
a= justdave


git-svn-id: svn://10.0.0.236/trunk@154078 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-18 03:57:05 +00:00
myk%mozilla.org
f34cbc746e Fix for bug 228917: Makes some flag SQL work with PostgreSQL by using the semantically equivalent INNER JOIN over a comma (,).
Patch by mkanat@kerio.com.
r=myk
a=myk


git-svn-id: svn://10.0.0.236/trunk@152105 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-31 00:49:56 +00:00
myk%mozilla.org
6d616e758d Fix for bug 183788: make request mail go out when a request is created and there's no requestee but there is a cc: list
git-svn-id: svn://10.0.0.236/trunk@148370 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-25 01:34:33 +00:00
bbaetz%acm.org
7d7d7e1532 Bug 208699 - Move Throw{Code,Template}Error into Error.pm
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-14 06:05:23 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
myk%mozilla.org
6d65c0a8ff Fix for bug 179510: takes group restrictions into account when sending request notifications
r=bbaetz,jpreed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@141792 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-25 05:41:29 +00:00
jeff.hedlund%matrixsi.com
2bda9e1546 Bug 179582 - More informative and easier to read flag email template
r=myk
a=myk


git-svn-id: svn://10.0.0.236/trunk@134157 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-20 03:03:21 +00:00
myk%mozilla.org
195afd1ecd Fix for bug 180632: corrects reference flag->is_requesteeble to flag->type->is_requesteeble
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@134026 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-17 23:33:54 +00:00
myk%mozilla.org
1c94919562 Last part of fix for bug 179494: adds "use Bugzilla::Util" and removes "&::" from before "trim" per bbaetz.
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@134021 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-17 22:50:59 +00:00
myk%mozilla.org
02ec7d08b8 Fix for bug 179494: prevents Bugzilla from thinking users have changed flags when they haven't.
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@134005 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-17 12:46:00 +00:00
bugreport%peshkin.net
98ee17fb1b Bug 179706 activity log needs to include full account names for requestees
r,a=myk


git-svn-id: svn://10.0.0.236/trunk@133735 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-13 07:05:41 +00:00
myk%mozilla.org
b0160244f2 Fix for bug 179334: updates the setter consistently. also fixes numerous other bugs in the RT code.
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@133564 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-11 12:36:27 +00:00