fb9eb2800c
r=ashuk
The following files are in the fix for this bug:
M CBrowserContainer.cpp
M CurrentPageImpl.cpp
M HistoryImpl.cpp
M NavigationImpl.cpp
Here is the reason for the bug:
User presses "Refresh" button. This causes the following code to be executed:
public void refresh(long loadFlags)
{
ParameterCheck.noLessThan(loadFlags, 0);
myFactory.throwExceptionIfNotInitialized();
Assert.assert(-1 != nativeWebShell);
synchronized(myBrowserControl) {
nativeRefresh(nativeWebShell, loadFlags);
}
}
In the process of refresh, on another thread, the user's
eventDispatched() method is called, which calls history.canBack():
public boolean canBack()
{
myFactory.throwExceptionIfNotInitialized();
Assert.assert(-1 != nativeWebShell);
boolean result = false;
synchronized(myBrowserControl) {
result = nativeCanBack(nativeWebShell);
}
return result;
}
This call blocks on trying to acquire the lock for myBrowserControl, and
the load can't proceed until canBack() returns. DEADLOCK.
-------------
The fix is to use PostEvent instead of PostSynchronous event. This
causes the call to nativeRefresh to return immediately.
git-svn-id: svn://10.0.0.236/branches/JAVADEV_RTM_20001102@86938 18797224-902f-48f8-a5cc-f745e15eee43
Here lies the code that comprises the java enhancers to mozilla. Authors: see the README files for each individual subdirectory Requirements: * JDK1.2 or greater (may work with lower versions, haven't checked). * Successfully built MOZ_DEBUG=1 Mozilla M13 tree. * Perl 5 perl.exe must be in your path How To Build: * make it so the directory in which this file resides is a child of your top level Mozilla M13 directory * make sure the environment var JDKHOME is set to your jdk installation directory, ie SET JDKHOME=C:\jdk1.2.2 * type "nmake /f makefile.win all" and hope for the best * this should compile the clasess into %MOZ_SRC%\dist\classes Problems: * clobber_all doesn't remove the .class files from dist\classes. You have to do this manually. * post to netscape.public.mozilla.java newsgroup General notes: * Please update the ChangeLog (changelo) files in the subdirectories when you make changes.