Bommels05/maven-plugins
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PR: MPCHANGELOG-47

Browse Source 
quote argument on Windows


git-svn-id: https://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk@179938 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
brett 2005-06-04 04:19:11 +00:00
parent cb36aaf659
commit 8740c9b54a
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
changelog/src/main/org/apache/maven/cvslib/CvsChangeLogGenerator.java
View File

@ -197,7 +197,12 @@ class CvsChangeLogGenerator extends AbstractChangeLogGenerator
protected String getScmDateArgument(Date before, Date to)
{
SimpleDateFormat outputDate = new SimpleDateFormat("yyyy-MM-dd");
return "-d " + outputDate.format(before) + "<" + outputDate.format(to);
String cmd = outputDate.format(before) + "<" + outputDate.format(to);
if ( System.getProperty( "os.name" ).startsWith( "Windows" ) )
{
cmd = "\"" + cmd + "\"";
}
return "-d " + cmd;
}
/**

4
changelog/src/test/org/apache/maven/cvslib/CvsChangeLogGeneratorTest.java
View File

@ -205,6 +205,10 @@ public class CvsChangeLogGeneratorTest extends TestCase
assertEquals("index " + index + ": clArgs.length", expected.length, clArgs.length);
for (int i = 0; i < expected.length; i++)
{
if ( clArgs[i].startsWith( "-d \"" ) )
{
clArgs[i] = "-d " + clArgs[i].substring( 4, clArgs[i].length() - 1 );
}
assertEquals("index " + index + ": clArgs[" + i + "]", expected[i], clArgs[i]);
}
}

1
changelog/xdocs/changes.xml
View File

@ -26,6 +26,7 @@
</properties>
<body>
<release version="1.8-SNAPSHOT" date="in SVN">
<action dev="brett" type="fix" issue="MPCHANGELOG-47">Quote argument with &lt; in it on Windows for the CVS provider - required if using CVSNT</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-55">Fix problem parsing revisions on Linux introduced by MPCHANGELOG-29</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-63" due-to="David Jackman">Add the ability to show several sets of changes</action>
<action dev="brett" type="fix" issue="MPCHANGELOG-23">Guess factory from connection</action>