Bommels05/maven-plugins
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PR: MPSCM-63

Browse Source 
Make prepare-release goal fail if project.xml or changes.xml can't be edited.

git-svn-id: https://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk@471398 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
ltheussl 2006-11-05 11:12:29 +00:00
parent 6b76859fec
commit 8cd968fba1
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scm/plugin.jelly
View File

@ -320,12 +320,20 @@
<!-- TODO: verify that the name is valid for a tag --> <!-- TODO: verify that the name is valid for a tag -->
<!-- Update project.xml --> <!-- Update project.xml -->
<j:set var="pomFilename" value="project.xml" />
<util:file var="file" name="${pomFilename}"/>
<j:if test="${!file.canWrite()}">
<ant:fail>project.xml is not writable!</ant:fail>
</j:if>
<t:release-version version="${version_name}" tag="${tag_name}" /> <t:release-version version="${version_name}" tag="${tag_name}" />
<!-- Update changes.xml if it exists --> <!-- Update changes.xml if it exists -->
<j:set var="changesFilename" value="${maven.docs.src}/changes.xml" /> <j:set var="changesFilename" value="${maven.docs.src}/changes.xml" />
<util:file var="file" name="${changesFilename}"/> <util:file var="file" name="${changesFilename}"/>
<j:if test="${file.exists()}"> <j:if test="${file.exists()}">
<j:if test="${!file.canWrite()}">
<ant:fail>changes.xml exists but is not writable!</ant:fail>
</j:if>
<c:release-version version="${version_name}" /> <c:release-version version="${version_name}" />
</j:if> </j:if>

1
scm/xdocs/changes.xml
View File

@ -24,6 +24,7 @@
</properties> </properties>
<body> <body>
<release version="1.6.1-SNAPSHOT" date="In SVN"> <release version="1.6.1-SNAPSHOT" date="In SVN">
<action dev="ltheussl" type="fix" issue="MPSCM-63">The prepare-release goal should fail if project.xml can't be edited (e.g. read only).</action>
<action dev="ltheussl" type="fix" issue="MPSCM-89">SCM Parse Connection output is wrong / misleading.</action> <action dev="ltheussl" type="fix" issue="MPSCM-89">SCM Parse Connection output is wrong / misleading.</action>
<action dev="ltheussl" type="fix" issue="MPSCM-86">scm:prepare-release does not commit modified changes.xml.</action> <action dev="ltheussl" type="fix" issue="MPSCM-86">scm:prepare-release does not commit modified changes.xml.</action>
<action dev="ltheussl" type="update">Update dom4j and jelly dependencies to match the ones in maven 1.1 core.</action> <action dev="ltheussl" type="update">Update dom4j and jelly dependencies to match the ones in maven 1.1 core.</action>