From ab73751157ffaf375885c4d296b4dd391f4135c8 Mon Sep 17 00:00:00 2001 From: ltheussl Date: Thu, 19 Jan 2006 21:47:50 +0000 Subject: [PATCH] PR: MPCHANGELOG-72 Submitted by: Pascal Larin Auto select factory from connection doesn't work if provider name length different from 3. git-svn-id: https://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk@370646 13f79535-47bb-0310-9956-ffa450edef68 --- .../main/org/apache/maven/changelog/ChangeLog.java | 13 ++++++++++--- changelog/xdocs/changes.xml | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/changelog/src/main/org/apache/maven/changelog/ChangeLog.java b/changelog/src/main/org/apache/maven/changelog/ChangeLog.java index a51d5d6f..bd5fac9a 100644 --- a/changelog/src/main/org/apache/maven/changelog/ChangeLog.java +++ b/changelog/src/main/org/apache/maven/changelog/ChangeLog.java @@ -503,15 +503,22 @@ public class ChangeLog { if ( clFactoryClass == null ) { - if ( ( connection == null ) || ( connection.length() < 7 ) + //Connection Format: scm:[:] + if ( ( connection == null ) || ( connection.length() < 5 ) || !connection.startsWith( "scm:" ) ) { LOG.warn( "Connection does not appear valid" ); } else { - clFactoryClass = - (String) FACTORIES.get( connection.substring( 4, 7 ) ); + int iProviderEnd = connection.indexOf( ":", 4 ); + if ( iProviderEnd == -1 ) + { + // Connection = scm: + iProviderEnd = connection.length(); + } + + clFactoryClass = (String) FACTORIES.get( connection.substring( 4, iProviderEnd ) ); } if ( clFactoryClass == null ) diff --git a/changelog/xdocs/changes.xml b/changelog/xdocs/changes.xml index 56dd4520..3e5c3357 100644 --- a/changelog/xdocs/changes.xml +++ b/changelog/xdocs/changes.xml @@ -25,6 +25,7 @@ + Auto select factory from connection doesn't work if provider name length different from 3. Add MKS SI support. Changelog returns 0 entries on Windows with CVS (not CVSNT). New property maven.changelog.quoteDate. Changelog plugin creates wrong links for Subversion repositories. New property maven.changelog.svn.baseurl.