Bommels05/maven-plugins
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Follow up to my last commit. The HashSet wasn't preserving order, so we

Browse Source 
should use a LinkedHashSet, but that isn't part of 1.3.  So we'll just
use an ArrayList and create a new list each time this goal is invoked
which will prevent duplicates from being added.


git-svn-id: https://svn.apache.org/repos/asf/maven/maven-1/plugins/trunk@112790 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
kaz 2003-01-31 18:58:49 +00:00
parent 2c9c349142
commit cbd81d7e9c
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
xdoc/plugin.jelly
View File

@ -431,7 +431,17 @@
<goal name="xdoc:register-reports">
<j:new var="reports" className="java.util.HashSet"/>
<!--
| This should be a LinkedHashSet to prevent someone from
| registering somthing twice. Unfortunately, 1.3 does not
| have a LinkedHashSet so I'll leave this here as a reminder
| for us someday. In the meantime, each time this goal is called,
| we'll just replace the old List with a new one. Shouldn't cause
| any problmes. When we do actually use the Set, we can put a check
| to see if 'reports' already exists, and if so, do nothing.
| <j:new var="reports" className="java.util.LinkedHashSet"/>
|-->
<j:new var="reports" className="java.util.ArrayList"/>
<j:set var="dummy" value="${pom.getPluginContext('maven-xdoc-plugin').setVariable('reports', reports)}"/>
<!--