TheHomecraft/MineOS
1
0
Fork 0
mirror of https://github.com/IgorTimofeev/MineOS.git synced 2025-12-20 11:09:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix materials.newDebugTexture and simplify

Browse Source 
I was testing a copy of this in Python, and noticed that bStep and sStep appear to be swapped, as bStep changed b up by 1/height, but the loop is by width, leading b to exceed 1 if the height is smaller than width. This is only apparent if the width and height of the new debug texture is not the same. And then I also noticed that the whole "invert blackSquare in two places" part could be simplified to if x + y is an odd number for each pixel in the texture. I don't claim to know the specifics of how to make lua faster, and this may be slower, so whatever is better.
This commit is contained in:
CoolCat467 2022-01-07 22:46:43 -06:00 committed by GitHub
parent 2af4200a57
commit 299acd9a91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/OpenComputersGL/Materials.lua
View File

@ -12,21 +12,11 @@ materials.types = {
function materials.newDebugTexture(width, height, h)
local texture = {width = width, height = height}
local bStep = 1 / height
local sStep = 1 / width
local s, b = 0, 0
local blackSquare = false
for y = 1, height do
texture[y] = {}
for x = 1, width do
texture[y][x] = blackSquare == true and 0x0 or color.HSBToInteger(h, s, b)
blackSquare = not blackSquare
b = b + bStep
texture[y][x] = not (x+y)%2 and 0x0 or color.HSBToInteger(h, y/height, x/width)
end
b = 0
s = s + sStep
blackSquare = not blackSquare
end
return texture
end