Merge pull request #14073 from fzakaria/fzakaria/shellcheck-functional-dependencies.builder0

shellcheck fix functional/dependencies.builder0.sh

maintainers/flake-module.nix

@@ -108,7 +108,6 @@
               # We haven't linted these files yet
               ''^scripts/install-systemd-multi-user\.sh$''
               ''^tests/functional/db-migration\.sh$''
-              ''^tests/functional/dependencies\.builder0\.sh$''
               ''^tests/functional/dump-db\.sh$''
               ''^tests/functional/dyn-drv/eval-outputOf\.sh$''
               ''^tests/functional/dyn-drv/old-daemon-error-hack\.sh$''

tests/functional/dependencies.builder0.sh

@@ -1,16 +1,20 @@
+# shellcheck shell=bash
+# shellcheck disable=SC2154
 [ "${input1: -2}" = /. ]
+# shellcheck disable=SC2154
 [ "${input2: -2}" = /. ]
 
-mkdir $out
-echo $(cat $input1/foo)$(cat $input2/bar) > $out/foobar
+# shellcheck disable=SC2154
+mkdir "$out"
+echo "$(cat "$input1"/foo)$(cat "$input2"/bar)" > "$out"/foobar
 
-ln -s $input2 $out/reference-to-input-2
+ln -s "$input2" "$out"/reference-to-input-2
 
 # Self-reference.
-ln -s $out $out/self
+ln -s "$out" "$out"/self
 
 # Executable.
-echo program > $out/program
-chmod +x $out/program
+echo program > "$out"/program
+chmod +x "$out"/program
 
 echo FOO