Merge pull request #8936 from NixOS/backport-8825-to-2.17-maintenance

[Backport 2.17-maintenance] src/libexpr/search-path.cc: avoid out-of-bounds read on string_view

src/libexpr/search-path.cc

@@ -10,7 +10,7 @@ std::optional<std::string_view> SearchPath::Prefix::suffixIfPotentialMatch(
 
     /* Non-empty prefix and suffix must be separated by a /, or the
        prefix is not a valid path prefix. */
-    bool needSeparator = n > 0 && (path.size() - n) > 0;
+    bool needSeparator = n > 0 && n < path.size();
 
     if (needSeparator && path[n] != '/') {
         return std::nullopt;