Explain that upcast_goal is still a static cast

2020-10-17 21:50:12 +00:00
parent 57d0432b39
commit 7ed46c1574
1 changed files with 5 additions and 1 deletions
--- a/src/libstore/build/worker.hh
+++ b/src/libstore/build/worker.hh
@@ -15,7 +15,11 @@ class SubstitutionGoal;

     class SubstitutionGoal : public Goal;

-   even when Goal is a complete type; */
+   even when Goal is a complete type.
+
+   This is still a static cast. The purpose of exporting it is to define it in
+   a place where `SubstitutionGoal` is concrete, and use it in a place where it
+   is opaque. */
 GoalPtr upcast_goal(std::shared_ptr<SubstitutionGoal> subGoal);

 typedef std::chrono::time_point<std::chrono::steady_clock> steady_time_point;