Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Last 4 items from bbaetz review bug 157756 comment 49

Browse Source 
git-svn-id: svn://10.0.0.236/branches/Groups_20020716_Branch@128709 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bugreport%peshkin.net
2002-09-03 17:38:01 +00:00
parent 077877c711
commit 0bb0108b90
4 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mozilla/webtools/bugzilla/Bugzilla/Search.pm
View File

@@ -321,10 +321,6 @@ sub init {
push(@wherepart, "$table.bug_id = bugs.bug_id");
$f = "$table.thetext";
},
"^groupset,(?!changed)" => sub {
&::ThrowUserError("Bugs no longer have a groupset field.
Instead, you can search on the bug group");
},
"^bug_group,(?!changed)" => sub {
push(@supptables, "LEFT JOIN bug_group_map bug_group_map_$chartid ON bugs.bug_id = bug_group_map_$chartid.bug_id");
@@ -760,8 +756,9 @@ sub init {
"If you think you're getting this in error, please copy the " .
"entire URL out of the address bar at the top of your browser " .
"window and email it to <109679\@bugzilla.org>";
$::vars->{'fieldname'} = html_quote($f);
die "Internal error: $errstr" if $chart < 0;
return Error($errstr);
&::ThrowUserError("illegal_fieldname");
}
# This is either from the internal chart (in which case we

8
mozilla/webtools/bugzilla/checksetup.pl
View File

@@ -3150,9 +3150,13 @@ if (GetFieldDef("profiles", "groupset")) {
while (my ($n) = $sth2->fetchrow_array) {
push @logrem, $n;
}
my $ladd = "";
my $lrem = "";
$ladd = join(", ", @logadd) . '?' if @logadd;
$lrem = join(", ", @logrem) . '?' if @logrem;
$dbh->do("UPDATE profiles_activity SET fieldid = $bgfid, newvalue = " .
$dbh->quote(join(", ", @logadd)) . ", oldvalue = " .
$dbh->quote(join(", ", @logrem)) .
$dbh->quote($ladd) . ", oldvalue = " .
$dbh->quote($lrem) .
" WHERE userid = $uid AND profiles_when = " .
$dbh->quote($uwhen) .
" AND who = $uwho AND fieldid = $gsid");

2
mozilla/webtools/bugzilla/editusers.cgi
View File

@@ -318,7 +318,7 @@ if ($action eq 'list') {
$query = "SELECT login_name,realname,disabledtext " .
"FROM profiles WHERE " . $::FORM{'query'} . " ORDER BY login_name";
} elsif (exists $::FORM{'group'}) {
$query = "SELECT DISTINCTROW login_name,realname,disabledtext " .
$query = "SELECT DISTINCT login_name,realname,disabledtext " .
"FROM profiles, user_group_map WHERE profiles.userid = user_group_map.user_id
AND group_id=" . $::FORM{'group'} . " ORDER BY login_name";
} else {

4
mozilla/webtools/bugzilla/template/en/default/global/messages.html.tmpl
View File

@@ -155,6 +155,10 @@
[% title = "Your Query Makes No Sense" %]
'<tt>[% date %]</tt>' is not a legal date.
[% ELSIF message_tag == "illegal_fieldname" %]
[% title = "Your Query Makes No Sense" %]
'<tt>[% fieldname %]</tt>' is not a legal fieldname.
[% ELSIF message_tag == "illegal_is_obsolete" %]
[% title = "Your Query Makes No Sense" %]
The only legal values for the <em>Attachment is obsolete</em> field are