Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Try to keep window.arguments from being wiped out by scope-clearing by setting

Browse Source 
the document in the window to null before setting window.arguments in
AttachArguments.  Bug 25040, r=danm, sr=jst


git-svn-id: svn://10.0.0.236/trunk@163138 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzbarsky%mit.edu
2004-10-02 16:11:57 +00:00
parent 71e6e23cc8
commit 1eceb876b2
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp
View File

@@ -1683,6 +1683,15 @@ nsWindowWatcher::AttachArguments(nsIDOMWindow *aWindow,
JSObject *args;
args = ::JS_NewArrayObject(cx, argc, argv);
if (args) {
// If this is an existing window that we're opening into, the document
// change in it will wipe out the JS scope. In particular it would clear
// the "arguments" property we're about to set. So set the document in
// the window to null right away, so that when the new document loads we
// don't clear the scope.
nsCOMPtr<nsIScriptGlobalObject> globalObject(do_GetInterface(aWindow));
if (globalObject) {
globalObject->SetNewDocument(nsnull, PR_TRUE, PR_TRUE);
}
jsval argsVal = OBJECT_TO_JSVAL(args);
// ::JS_DefineProperty(cx, window_obj, "arguments",
// argsVal, NULL, NULL, JSPROP_PERMANENT);