Bug 1068521: "Use of uninitialized value" warnings

r=glob,a=glob


git-svn-id: svn://10.0.0.236/trunk@265578 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org
2014-09-18 09:15:46 +00:00
parent dd63c49852
commit 240a81000c
4 changed files with 14 additions and 7 deletions

View File

@@ -1 +1 @@
9140
9141

View File

@@ -1 +1 @@
af46080505c3103888846c59551f41e0af823bb1
c07333d9c122bd6751e31dae5a7c49901f6518b2

View File

@@ -373,10 +373,7 @@ sub param {
if (!scalar(@result)
&& $self->request_method && $self->request_method eq 'POST')
{
# Some servers fail to set the QUERY_STRING parameter, which
# causes undef issues
$ENV{'QUERY_STRING'} = '' unless exists $ENV{'QUERY_STRING'};
@result = $self->SUPER::url_param(@_);
@result = $self->url_param(@_);
}
# Fix UTF-8-ness of input parameters.
@@ -401,6 +398,14 @@ sub param {
return $self->SUPER::param(@_);
}
sub url_param {
my $self = shift;
# Some servers fail to set the QUERY_STRING parameter, which
# causes undef issues
$ENV{'QUERY_STRING'} //= '';
return $self->SUPER::url_param(@_);
}
sub _fix_utf8 {
my $input = shift;
# The is_utf8 is here in case CGI gets smart about utf8 someday.
@@ -732,6 +737,8 @@ L<CGI|CGI>, L<CGI::Cookie|CGI::Cookie>
=item param
=item url_param
=item header
=back

View File

@@ -234,7 +234,7 @@ if (should_set('keywords')) {
}
if (should_set('comment')) {
my $is_markdown = ($user->settings->{use_markdown}->{is_enabled} &&
$cgi->param('use_markdown') eq '1') ? 1 : 0;
$cgi->param('use_markdown')) ? 1 : 0;
$set_all_fields{comment} = {
body => scalar $cgi->param('comment'),