Bug 406032: Block update info urls that are not http/https. r=robstrong,
a=schrep git-svn-id: svn://10.0.0.236/trunk@240298 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
@@ -1164,12 +1164,19 @@ function onAddonSelect(aEvent)
|
||||
}
|
||||
else if (gView == "updates") {
|
||||
UpdateInfoLoader.cancelLoad();
|
||||
if (!gExtensionsView.selectedItem)
|
||||
if (!gExtensionsView.selectedItem) {
|
||||
previewImageDeck.selectedIndex = 3;
|
||||
else if (!gExtensionsView.selectedItem.hasAttribute("availableUpdateInfo"))
|
||||
previewImageDeck.selectedIndex = 4;
|
||||
else
|
||||
UpdateInfoLoader.loadInfo(gExtensionsView.selectedItem.getAttribute("availableUpdateInfo"));
|
||||
}
|
||||
else {
|
||||
try {
|
||||
var uri = makeURI(gExtensionsView.selectedItem.getAttribute("availableUpdateInfo"));
|
||||
var scheme = uri.scheme;
|
||||
} catch (ex) {}
|
||||
if (uri && (scheme == "http" || scheme == "https"))
|
||||
UpdateInfoLoader.loadInfo(uri.spec);
|
||||
else
|
||||
previewImageDeck.selectedIndex = 4;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1989,11 +1996,9 @@ var gExtensionsViewController = {
|
||||
if (!aSelectedItem) return;
|
||||
var homepageURL = aSelectedItem.getAttribute("homepageURL");
|
||||
// only allow http(s) homepages
|
||||
var scheme = "";
|
||||
var uri = null;
|
||||
try {
|
||||
uri = makeURI(homepageURL);
|
||||
scheme = uri.scheme;
|
||||
var uri = makeURI(homepageURL);
|
||||
var scheme = uri.scheme;
|
||||
} catch (ex) {}
|
||||
if (uri && (scheme == "http" || scheme == "https"))
|
||||
openURL(uri.spec);
|
||||
|
||||
Reference in New Issue
Block a user