Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

14602: IsEditable is broken.

Browse Source 
removed optimization where we searched text strings and made our own guess about
  whether it was editable or not.  Now we just trust layout, if there's a frame, it's editable.


git-svn-id: svn://10.0.0.236/trunk@48881 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
buster%netscape.com
1999-09-23 00:10:51 +00:00
parent 7eab9cadfe
commit 3f8d33af18
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mozilla/editor/base/nsEditor.cpp
View File

@@ -2826,6 +2826,13 @@ nsEditor::IsEditable(nsIDOMNode *aNode)
return PR_FALSE;
}
}
// this next block testing for char data is ifdef'd out
// because it's unclear what whitespace constitutes "not editable"
// it's just an optimization, which makes the assumption that
// scanning the text is faster than asking layout if the text has a frame
// the last block will do this for all content, including text
#ifdef BUSTER_PERFORMANCE
// it's not the bogus node, so see if it is an irrelevant text node
if (PR_TRUE==IsTextNode(aNode))
{
@@ -2844,13 +2851,15 @@ nsEditor::IsEditable(nsIDOMNode *aNode)
PRUint32 i;
for (i=0; i<length; i++)
{
if ('\n'!=data.CharAt(i)) {
PRUnichar character = data.CharAt(i);
if (('\n'!=character) && ('\r'!=character)) {
return PR_TRUE;
}
}
return PR_FALSE;
}
}
#endif
// we got this far, so see if it has a frame. If so, we'll edit it.
nsIFrame *resultFrame;

11
mozilla/editor/libeditor/base/nsEditor.cpp
View File

@@ -2826,6 +2826,13 @@ nsEditor::IsEditable(nsIDOMNode *aNode)
return PR_FALSE;
}
}
// this next block testing for char data is ifdef'd out
// because it's unclear what whitespace constitutes "not editable"
// it's just an optimization, which makes the assumption that
// scanning the text is faster than asking layout if the text has a frame
// the last block will do this for all content, including text
#ifdef BUSTER_PERFORMANCE
// it's not the bogus node, so see if it is an irrelevant text node
if (PR_TRUE==IsTextNode(aNode))
{
@@ -2844,13 +2851,15 @@ nsEditor::IsEditable(nsIDOMNode *aNode)
PRUint32 i;
for (i=0; i<length; i++)
{
if ('\n'!=data.CharAt(i)) {
PRUnichar character = data.CharAt(i);
if (('\n'!=character) && ('\r'!=character)) {
return PR_TRUE;
}
}
return PR_FALSE;
}
}
#endif
// we got this far, so see if it has a frame. If so, we'll edit it.
nsIFrame *resultFrame;