Bug 489188, patch v4, avoid creation of unnecessary NULLARGUMENT error object, patch by Wan-Teh, r=kaie

git-svn-id: svn://10.0.0.236/trunk@263905 18797224-902f-48f8-a5cc-f745e15eee43
2012-06-06 15:46:30 +00:00
parent 41b76c7f5f
commit 51d72ea3d6
1 changed files with 4 additions and 4 deletions
--- a/mozilla/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c
+++ b/mozilla/security/nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_cert.c
@@ -2397,15 +2397,15 @@ PKIX_PL_Cert_GetExtendedKeyUsage(
                                PKIX_DECREF(pkixOID);
                        }

+                        PKIX_CHECK(PKIX_List_SetImmutable
+                                    (oidsList, plContext),
+                                    PKIX_LISTSETIMMUTABLEFAILED);
+
                        /* save a cached copy in case it is asked for again */
                        cert->extKeyUsages = oidsList;
                        oidsList = NULL;
                }

-                PKIX_CHECK(PKIX_List_SetImmutable
-                            (cert->extKeyUsages, plContext),
-                            PKIX_LISTSETIMMUTABLEFAILED);
-
                PKIX_OBJECT_UNLOCK(cert);
        }