Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 338441

Browse Source 
Make tabbrowser's ".browsers" property faster (Toolkit version)
r+a=mconnor


git-svn-id: svn://10.0.0.236/trunk@232729 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
cst%andrew.cmu.edu
2007-08-22 05:03:55 +00:00
parent 9795f9024c
commit 52c570c868
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
mozilla/browser/base/content/tabbrowser.xml
View File

@@ -190,6 +190,9 @@
<field name="mAddProgressListenerWasCalled">
false
</field>
<field name="_browsers">
null
</field>
<method name="getBrowserAtIndex">
<parameter name="aIndex"/>
@@ -1072,6 +1075,8 @@
<parameter name="aAllowThirdPartyFixup"/>
<body>
<![CDATA[
this._browsers = null; // invalidate cache
if (!this.mTabbedMode)
this.enterTabbedMode();
@@ -1267,6 +1272,7 @@
<parameter name="aTab"/>
<body>
<![CDATA[
this._browsers = null; // invalidate cache
if (aTab.localName != "tab")
aTab = this.mCurrentTab;
@@ -1529,12 +1535,15 @@
<property name="browsers" readonly="true">
<getter>
<![CDATA[
var browsers = [];
var i;
browsers.item = function(i) {return this[i];}
for (i = 0; i < this.mTabContainer.childNodes.length; i++)
browsers.push(this.mTabContainer.childNodes[i].linkedBrowser);
return browsers;
if (!this._browsers) {
var browsers = [];
var i;
browsers.item = function(i) {return this[i];}
for (i = 0; i < this.mTabContainer.childNodes.length; i++)
browsers.push(this.mTabContainer.childNodes[i].linkedBrowser);
this._browsers = browsers;
}
return this._browsers;
]]>
</getter>
</property>
@@ -1677,6 +1686,7 @@
<parameter name="aIndex"/>
<body>
<![CDATA[
this._browsers = null; // invalidate cache
this.mTabFilters.splice(aIndex, 0, this.mTabFilters.splice(aTab._tPos, 1)[0]);
this.mTabListeners.splice(aIndex, 0, this.mTabListeners.splice(aTab._tPos, 1)[0]);