Bug 337747: config.cgi fails with an SQL error in Bugzilla::Keyword with no keywords defined
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>; r=mkanat; a=justdave git-svn-id: svn://10.0.0.236/trunk@196708 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
parent
d51b6ef7ef
commit
56e1261c6f
@ -82,7 +82,7 @@ sub new_from_list {
|
||||
my $dbh = Bugzilla->dbh;
|
||||
|
||||
my $keywords;
|
||||
if ($id_list) {
|
||||
if (@$id_list) {
|
||||
my @detainted_ids;
|
||||
foreach my $id (@$id_list) {
|
||||
detaint_natural($id) ||
|
||||
@ -94,9 +94,7 @@ sub new_from_list {
|
||||
"SELECT $columns FROM keyworddefs WHERE id IN ("
|
||||
. join(',', @detainted_ids) . ")", {Slice=>{}});
|
||||
} else {
|
||||
ThrowCodeError('bad_arg',
|
||||
{argument => 'id_list',
|
||||
function => 'Bugzilla::Keyword::new_from_list'});
|
||||
return [];
|
||||
}
|
||||
|
||||
foreach my $keyword (@$keywords) {
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user