Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 423154 - off-by-one error for browser.bookmarks.max_backups (r=mano)

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@248223 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
dietrich%mozilla.com 2008-03-19 23:14:45 +00:00
parent 52c618cc21
commit 60f86948c7
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mozilla/toolkit/components/places/src/utils.js
View File

@ -1411,19 +1411,30 @@ var PlacesUtils = {
}
}
if (aNumberOfBackups > 0 && backupFileNames.length >= aNumberOfBackups) {
var numberOfBackupsToDelete = backupFileNames.length - aNumberOfBackups;
var numberOfBackupsToDelete = 0;
if (aNumberOfBackups > -1)
numberOfBackupsToDelete = backupFileNames.length - aNumberOfBackups;
if (numberOfBackupsToDelete > 0) {
// If we don't have today's backup, remove one more so that
// the total backups after this operation does not exceed the
// number specified in the pref.
if (!backupFile)
numberOfBackupsToDelete++;
backupFileNames.sort();
while (numberOfBackupsToDelete--) {
backupFile = bookmarksBackupDir.clone();
let backupFile = bookmarksBackupDir.clone();
backupFile.append(backupFileNames[0]);
backupFile.remove(false);
backupFileNames.shift();
}
}
if (backupFile)
return; // already have today's backup, job done
// do nothing if we either have today's backup already
// or the user has set the pref to zero.
if (backupFile || aNumberOfBackups == 0)
return;
}
backupFile = bookmarksBackupDir.clone();