Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed some memory leaks

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@20677 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
troy%netscape.com
1999-02-14 05:44:39 +00:00
parent dc4dd5e2b6
commit 658dac2de0
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mozilla/base/src/nsProperties.cpp
View File

@@ -162,7 +162,7 @@ nsProperties::SetProperty(const nsString& aKey, nsString& aNewValue,
}
}
PRUnichar *key = aKey.ToNewUnicode();
const PRUnichar *key = aKey.GetUnicode(); // returns internal pointer (not a copy)
PRUint32 len;
PRUint32 hashValue = nsCRT::HashValue(key, &len);
PLHashEntry **hep = PL_HashTableRawLookup(mTable, hashValue, key);
@@ -170,7 +170,10 @@ nsProperties::SetProperty(const nsString& aKey, nsString& aNewValue,
if (he && aOldValue) {
// XXX fix me
}
PL_HashTableRawAdd(mTable, hep, hashValue, key, aNewValue.ToNewString());
// XXX Why add a new nsString object as the value? That causes an extra heap
// allocation, and we should just add a PRUnichar* like we do for the key...
PL_HashTableRawAdd(mTable, hep, hashValue, aKey.ToNewUnicode(),
aNewValue.ToNewString());
return NS_OK;
}
@@ -194,7 +197,7 @@ nsProperties::Subclass(nsIProperties* aSubclass)
NS_IMETHODIMP
nsProperties::GetProperty(const nsString& aKey, nsString& aValue)
{
PRUnichar *key = aKey;
const PRUnichar *key = aKey;
PRUint32 len;
PRUint32 hashValue = nsCRT::HashValue(key, &len);
PLHashEntry **hep = PL_HashTableRawLookup(mTable, hashValue, key);

9
mozilla/xpcom/ds/nsProperties.cpp
View File

@@ -162,7 +162,7 @@ nsProperties::SetProperty(const nsString& aKey, nsString& aNewValue,
}
}
PRUnichar *key = aKey.ToNewUnicode();
const PRUnichar *key = aKey.GetUnicode(); // returns internal pointer (not a copy)
PRUint32 len;
PRUint32 hashValue = nsCRT::HashValue(key, &len);
PLHashEntry **hep = PL_HashTableRawLookup(mTable, hashValue, key);
@@ -170,7 +170,10 @@ nsProperties::SetProperty(const nsString& aKey, nsString& aNewValue,
if (he && aOldValue) {
// XXX fix me
}
PL_HashTableRawAdd(mTable, hep, hashValue, key, aNewValue.ToNewString());
// XXX Why add a new nsString object as the value? That causes an extra heap
// allocation, and we should just add a PRUnichar* like we do for the key...
PL_HashTableRawAdd(mTable, hep, hashValue, aKey.ToNewUnicode(),
aNewValue.ToNewString());
return NS_OK;
}
@@ -194,7 +197,7 @@ nsProperties::Subclass(nsIProperties* aSubclass)
NS_IMETHODIMP
nsProperties::GetProperty(const nsString& aKey, nsString& aValue)
{
PRUnichar *key = aKey;
const PRUnichar *key = aKey;
PRUint32 len;
PRUint32 hashValue = nsCRT::HashValue(key, &len);
PLHashEntry **hep = PL_HashTableRawLookup(mTable, hashValue, key);