Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sigh. allow dependent windows without parents because the Mozilla code will try to do that

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@90573 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
danm%netscape.com
2001-03-27 23:19:12 +00:00
parent 5d30ca2ef8
commit 6ee1a148db
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mozilla/xpfe/bootstrap/nsWindowCreator.cpp
View File

@@ -83,9 +83,16 @@ nsWindowCreator::CreateChromeWindow(nsIWebBrowserChrome *aParent,
convention suggests this method only be used when there is no parent
window (otherwise, just call Open() on the parent). However, we
should say something, just to be sure: */
if (aParent || (aChromeFlags & nsIWebBrowserChrome::CHROME_DEPENDENT))
NS_ASSERTION(!aParent, "window creator reached with non-null parent");
if (aParent)
return NS_ERROR_INVALID_ARG;
/* And you really shouldn't be making dependent windows without a parent.
But unparented modal (and therefore dependent) windows happen
in our codebase, so we allow it after some bellyaching: */
if (aChromeFlags & nsIWebBrowserChrome::CHROME_DEPENDENT)
NS_WARNING("dependent window created without a parent");
nsCOMPtr<nsIAppShellService> appShell(do_GetService(kAppShellServiceCID));
if (!appShell)
return NS_ERROR_FAILURE;