Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 780028: Oracle crashes if a column listed in ORDER BY appears twice in SELECT

Browse Source 
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264112 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org
2012-08-03 10:30:46 +00:00
parent 2f2e2b2b64
commit 70ad73028d
2 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
8327
8328

17
mozilla/webtools/bugzilla/Bugzilla/Search.pm
View File

@@ -835,10 +835,19 @@ sub _add_extra_column {
# These are the columns that we're going to be actually SELECTing.
sub _display_columns {
my ($self) = @_;
# Do not alter the list specified here at all, even if they are duplicated.
# Those are passed by the caller, and the caller expects to get them back
# in the exact same order.
$self->{display_columns} ||= [$self->_input_columns, $self->_extra_columns];
return @{ $self->{display_columns} } if $self->{display_columns};
# Do not alter the list from _input_columns at all, even if there are
# duplicated columns. Those are passed by the caller, and the caller
# expects to get them back in the exact same order.
my @columns = $self->_input_columns;
# Only add columns which are not already listed.
my %list = map { $_ => 1 } @columns;
foreach my $column ($self->_extra_columns) {
push(@columns, $column) unless $list{$column}++;
}
$self->{display_columns} = \@columns;
return @{ $self->{display_columns} };
}