Fix bug 299419: crash on Mac on double-click-hold in a text widget. We crashed in the context-click timer callback dereferencing a null mCurrentTarget, which gets nulled out when SetMouseDownState() dispatches a selection changed event. Fixed by moving the mouse event higher up, while mCurrentTarget is still good. r/sr=roc

git-svn-id: svn://10.0.0.236/trunk@176118 18797224-902f-48f8-a5cc-f745e15eee43

mozilla/content/events/src/nsEventStateManager.cpp

@@ -1270,22 +1270,28 @@ nsEventStateManager::FireContextClick()
       }
 
       if (allowedToDispatch) {
+        // make sure the widget sticks around
+        nsCOMPtr<nsIWidget> targetWidget(mCurrentTarget->GetWindow());
+        // init the event while mCurrentTarget is still good
+        nsMouseEvent event(PR_TRUE, NS_CONTEXTMENU,
+                           targetWidget,
+                           nsMouseEvent::eReal);
+        event.clickCount = 1;
+        FillInEventFromGestureDown(&event);
+        
         // stop selection tracking, we're in control now
         nsCOMPtr<nsIFrameSelection> frameSel;
         GetSelection(mCurrentTarget, mPresContext, getter_AddRefs(frameSel));
         if (frameSel) {
           PRBool mouseDownState = PR_TRUE;
           frameSel->GetMouseDownState(&mouseDownState);
-          if (mouseDownState)
+          if (mouseDownState) {
+            // note that this can cause selection changed events to fire if we're in
+            // a text field, which will null out mCurrentTarget
             frameSel->SetMouseDownState(PR_FALSE);
+          }
         }
 
-        nsMouseEvent event(PR_TRUE, NS_CONTEXTMENU,
-                           mCurrentTarget->GetWindow(),
-                           nsMouseEvent::eReal);
-        event.clickCount = 1;
-        FillInEventFromGestureDown(&event);
-
         // dispatch to DOM
         mGestureDownContent->HandleDOMEvent(mPresContext, &event, nsnull,
                                             NS_EVENT_FLAG_INIT, &status);