Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use mkstemp instead of tempnam. Potential security issue.

Browse Source 
Bug #173178 r=syd sr=dveditz


git-svn-id: svn://10.0.0.236/trunk@135129 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
seawood%netscape.com
2002-12-11 14:50:15 +00:00
parent 3a3c75b9f7
commit 8c0e151ae6
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
mozilla/xpinstall/wizard/unix/src2/nsXIEngine.cpp
View File

@@ -549,15 +549,27 @@ int
nsXIEngine::MakeUniqueTmpDir()
{
int err = E_DIR_CREATE;
mTmp = tempnam( (const char *) NULL, "xpi" );
if ( mTmp != (char *) NULL ) {
int tmperr;
tmperr = mkdir(mTmp, 0755);
if ( tmperr != -1 )
err = OK;
char tmpnam[MAXPATHLEN];
char *tmpdir = getenv("TMPDIR");
if (!tmpdir) tmpdir = getenv("TMP");
if (!tmpdir) tmpdir = getenv("TEMP");
if (!tmpdir) tmpdir = P_tmpdir;
snprintf(tmpnam, sizeof(tmpnam), "%s/xpi.XXXXXX", tmpdir);
#ifdef HAVE_MKDTEMP
if (mkdtemp(tmpnam)) {
mTmp = strdup(tmpnam);
if (mTmp) err = OK;
}
#else
int fd = mkstemp(tmpnam);
if (fd < 0) return err;
close(fd);
if (unlink(tmpnam) < 0) return err;
mTmp = strdup(tmpnam);
if (!mTmp) return err;
if (mkdir(mTmp, 0755) < 0) return err;
err = OK;
#endif
return err;
}