Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Memory Leak fixes

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@13495 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
spider%netscape.com
1998-10-26 22:57:37 +00:00
parent 843ee0f1c6
commit 8e40fcd4a6
3 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
mozilla/xpfc/canvas/src/nsXPFCCanvas.cpp
View File

@@ -137,7 +137,10 @@ nsXPFCCanvas :: ~nsXPFCCanvas()
}
if (nsnull != mView)
{
mView->SetParent(nsnull);
mView->Destroy();
}
}
@@ -607,8 +610,6 @@ nsresult nsXPFCCanvas :: LoadView(const nsCID &aViewClassIID,
else if (GetParent() != nsnull)
view = GetParent()->GetView();
nsViewClip clip ;
mView->Init(gXPFCToolkit->GetViewManager(),
bounds,
view,

20
mozilla/xpfc/parser/src/nsXPFCToolbarManager.cpp
View File

@@ -33,8 +33,23 @@ nsXPFCToolbarManager :: nsXPFCToolbarManager()
nsXPFCToolbarManager :: ~nsXPFCToolbarManager()
{
if (mToolbars != nsnull)
{
if (mToolbars != nsnull) {
nsIIterator * iterator;
mToolbars->CreateIterator(&iterator);
iterator->Init();
nsIXPFCToolbar * item;
while(!(iterator->IsDone()))
{
item = (nsIXPFCToolbar *) iterator->CurrentItem();
NS_RELEASE(item);
iterator->Next();
}
NS_RELEASE(iterator);
mToolbars->RemoveAll();
NS_RELEASE(mToolbars);
}
@@ -64,6 +79,7 @@ nsresult nsXPFCToolbarManager :: Init()
nsresult nsXPFCToolbarManager :: AddToolbar(nsIXPFCToolbar * aToolbar)
{
mToolbars->Append(aToolbar);
NS_ADDREF(aToolbar);
return NS_OK ;
}

5
mozilla/xpfc/parser/src/nsXPFCXMLContentSink.cpp
View File

@@ -357,7 +357,7 @@ NS_IMETHODIMP nsXPFCXMLContentSink::OpenContainer(const nsIParserNode& aNode)
}
// XXX: Really need this for all states
if (mState == XPFC_PARSING_STATE_MENUBAR)
if (mState == XPFC_PARSING_STATE_MENUBAR || mState == XPFC_PARSING_STATE_TOOLBAR)
NS_RELEASE(object);
return NS_OK;
@@ -454,7 +454,7 @@ NS_IMETHODIMP nsXPFCXMLContentSink::AddLeaf(const nsIParserNode& aNode)
}
// XXX: Really need this for all states
if (mState == XPFC_PARSING_STATE_MENUBAR)
if (mState == XPFC_PARSING_STATE_MENUBAR || mState == XPFC_PARSING_STATE_TOOLBAR)
NS_RELEASE(object);
return NS_OK;
@@ -817,6 +817,7 @@ NS_IMETHODIMP nsXPFCXMLContentSink::AddToHierarchy(nsIXMLParserObject& aObject,
mXPFCStack->Push(child_canvas);
NS_IF_RELEASE(child_canvas);
NS_IF_RELEASE(container);
return NS_OK;