Followup for bug 369767. Remove old workaround for the bug in our menu overlay, hide about menu item separator like we do for prefs and quit. b=369767 r=mano

git-svn-id: svn://10.0.0.236/trunk@222525 18797224-902f-48f8-a5cc-f745e15eee43

mozilla/browser/base/content/baseMenuOverlay.xul

@@ -97,21 +97,16 @@
                   label="&helpReleaseNotes.label;"
                   oncommand="openReleaseNotes(event)"
                   onclick="checkForMiddleClick(this, event);"/>
-        <menuseparator id="aboutSeparator"/>
+        <menuseparator/>
         <menuitem id="checkForUpdates"
                   accesskey="&updateCmd.accesskey;"
                   label="&updateCmd.label;"
                   class="menuitem-iconic"
                   oncommand="checkForUpdates();"/>
-#ifndef XP_MACOSX
-        <menuseparator/>
-#endif
+        <menuseparator id="aboutSeparator"/>
         <menuitem id="aboutName"
                   accesskey="&aboutCmd.accesskey;"
                   label="&aboutCmd.label;"
-#ifdef XP_MACOSX
-                  hidden="true"
-#endif
                   oncommand="openAboutDialog();"/>
       </menupopup>
     </menu>

mozilla/widget/src/cocoa/nsMenuBarX.mm

@@ -253,7 +253,8 @@ nsMenuBarX::AquifyMenuBar()
 {
   nsCOMPtr<nsIDOMDocument> domDoc(do_QueryInterface(mMenuBarContent->GetDocument()));
   if (domDoc) {
-    // remove the "About..." menu item
+    // remove the "About..." item and its separator
+    HideItem(domDoc, NS_LITERAL_STRING("aboutSeparator"), nsnull);
     HideItem(domDoc, NS_LITERAL_STRING("aboutName"), getter_AddRefs(mAboutItemContent));
     if (!sAboutItemContent)
       sAboutItemContent = mAboutItemContent;