Fix bug 323028 -- don't set our mRequest until after the clone is

done. r+sr=dbaron, a=dveditz


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_0_BRANCH@190971 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzbarsky%mit.edu
2006-02-23 02:46:38 +00:00
parent 92e7de8681
commit 99bd9386cd

View File

@@ -123,7 +123,13 @@ nsImageLoader::Load(imgIRequest *aImage)
mRequest = nsnull;
}
return aImage->Clone(this, getter_AddRefs(mRequest));
// Make sure to clone into a temporary, then set mRequest, since
// cloning may notify and we don't want to trigger paints from this
// code.
nsCOMPtr<imgIRequest> newRequest;
nsresult rv = aImage->Clone(this, getter_AddRefs(newRequest));
mRequest.swap(newRequest);
return rv;
}