Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 56851, regression in XPInstall dialog. r=jst, sr=vidur

Browse Source 
git-svn-id: svn://10.0.0.236/trunk@81482 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mstoltz%netscape.com 2000-10-19 22:21:57 +00:00
parent 0a10896512
commit 9f6c7e98d5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mozilla/dom/src/base/nsGlobalWindow.cpp
View File

@ -3044,13 +3044,16 @@ NS_IMETHODIMP GlobalWindowImpl::OpenInternal(JSContext *cx,
nsCOMPtr<nsIScriptSecurityManager> secMan;
if (uriToLoad) {
// Get security manager, check to see if URI is allowed.
// Don't call CheckLoadURI for dialogs - see bug 56851
// The security of this function depends on window.openDialog being
// inaccessible from web scripts
nsCOMPtr<nsIURI> newUrl;
nsCOMPtr<nsIScriptContext> scriptCX;
nsJSUtils::nsGetStaticScriptContext(cx, (JSObject *) mScriptObject,
getter_AddRefs(scriptCX));
if (!scriptCX ||
NS_FAILED(scriptCX->GetSecurityManager(getter_AddRefs(secMan))) ||
NS_FAILED(secMan->CheckLoadURIFromScript(cx, uriToLoad)))
((!aDialog && NS_FAILED(secMan->CheckLoadURIFromScript(cx, uriToLoad)))))
return NS_ERROR_FAILURE;
}