Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixing some redundant ref counting and a leak of the autocomplete data

Browse Source 
source. r=hyatt.


git-svn-id: svn://10.0.0.236/trunk@122223 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
pinkerton%netscape.com
2002-05-28 18:42:21 +00:00
parent 12c97ff0d7
commit a2c8c4faa4
8 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/camino/CHAutoCompleteDataSource.mm
View File

@@ -33,7 +33,7 @@
{
if ((self = [super init])) {
mResults = nil;
mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease];
mIconImage = [NSImage imageNamed:@"globe_ico"];
}
return self;
}

4
mozilla/camino/CHAutoCompleteTextField.mm
View File

@@ -96,7 +96,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[mTableView setAction:@selector(onRowClicked:)];
// Create the icon column if we have a proxy icon
if (mProxyIcon != nil) {
if (mProxyIcon) {
column = [[[NSTableColumn alloc] initWithIdentifier:@"icon"] autorelease];
[column setWidth:[mProxyIcon frame].origin.x + [mProxyIcon frame].size.width];
dataCell = [[[NSImageCell alloc] initImageCell:nil] autorelease];
@@ -121,7 +121,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[scrollView setDocumentView: mTableView];
// construct the datasource
mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];
mDataSource = [[CHAutoCompleteDataSource alloc] init];
[mTableView setDataSource: mDataSource];
[mPopupWin setContentView:scrollView];

2
mozilla/camino/src/browser/AutoCompleteDataSource.mm
View File

@@ -33,7 +33,7 @@
{
if ((self = [super init])) {
mResults = nil;
mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease];
mIconImage = [NSImage imageNamed:@"globe_ico"];
}
return self;
}

4
mozilla/camino/src/browser/AutoCompleteTextField.mm
View File

@@ -96,7 +96,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[mTableView setAction:@selector(onRowClicked:)];
// Create the icon column if we have a proxy icon
if (mProxyIcon != nil) {
if (mProxyIcon) {
column = [[[NSTableColumn alloc] initWithIdentifier:@"icon"] autorelease];
[column setWidth:[mProxyIcon frame].origin.x + [mProxyIcon frame].size.width];
dataCell = [[[NSImageCell alloc] initImageCell:nil] autorelease];
@@ -121,7 +121,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[scrollView setDocumentView: mTableView];
// construct the datasource
mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];
mDataSource = [[CHAutoCompleteDataSource alloc] init];
[mTableView setDataSource: mDataSource];
[mPopupWin setContentView:scrollView];

2
mozilla/chimera/CHAutoCompleteDataSource.mm
View File

@@ -33,7 +33,7 @@
{
if ((self = [super init])) {
mResults = nil;
mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease];
mIconImage = [NSImage imageNamed:@"globe_ico"];
}
return self;
}

4
mozilla/chimera/CHAutoCompleteTextField.mm
View File

@@ -96,7 +96,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[mTableView setAction:@selector(onRowClicked:)];
// Create the icon column if we have a proxy icon
if (mProxyIcon != nil) {
if (mProxyIcon) {
column = [[[NSTableColumn alloc] initWithIdentifier:@"icon"] autorelease];
[column setWidth:[mProxyIcon frame].origin.x + [mProxyIcon frame].size.width];
dataCell = [[[NSImageCell alloc] initImageCell:nil] autorelease];
@@ -121,7 +121,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[scrollView setDocumentView: mTableView];
// construct the datasource
mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];
mDataSource = [[CHAutoCompleteDataSource alloc] init];
[mTableView setDataSource: mDataSource];
[mPopupWin setContentView:scrollView];

2
mozilla/chimera/src/browser/AutoCompleteDataSource.mm
View File

@@ -33,7 +33,7 @@
{
if ((self = [super init])) {
mResults = nil;
mIconImage = [[NSImage imageNamed:@"globe_ico"] autorelease];
mIconImage = [NSImage imageNamed:@"globe_ico"];
}
return self;
}

4
mozilla/chimera/src/browser/AutoCompleteTextField.mm
View File

@@ -96,7 +96,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[mTableView setAction:@selector(onRowClicked:)];
// Create the icon column if we have a proxy icon
if (mProxyIcon != nil) {
if (mProxyIcon) {
column = [[[NSTableColumn alloc] initWithIdentifier:@"icon"] autorelease];
[column setWidth:[mProxyIcon frame].origin.x + [mProxyIcon frame].size.width];
dataCell = [[[NSImageCell alloc] initImageCell:nil] autorelease];
@@ -121,7 +121,7 @@ NS_IMPL_ISUPPORTS1(AutoCompleteListener, nsIAutoCompleteListener)
[scrollView setDocumentView: mTableView];
// construct the datasource
mDataSource = [[[CHAutoCompleteDataSource alloc] init] retain];
mDataSource = [[CHAutoCompleteDataSource alloc] init];
[mTableView setDataSource: mDataSource];
[mPopupWin setContentView:scrollView];