Bug 343801 - History menu jumps around (disappears) since addition of new Recently Closed Tabs menu item. r=gavin, a=mtschrep.

git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@201820 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mozilla.mano%sent.com
2006-07-10 17:28:49 +00:00
parent 462b5dae40
commit a431c0606e
2 changed files with 8 additions and 4 deletions

View File

@@ -374,7 +374,7 @@
oncommand="var url = event.target.getAttribute('statustext'); if (url) openUILink(url, event, false, true);"
onclick="checkForMiddleClick(this, event);">
<menupopup id="goPopup" onpopupshowing="updateGoMenu(this);" onpopuphiding="onGoMenuHidden();">
<menupopup id="goPopup" onpopupshowing="updateGoMenu(event, this);" onpopuphiding="onGoMenuHidden(event);">
<menuitem label="&backCmd.label;"
#ifdef XP_MACOSX
key="goBackKb2"

View File

@@ -1653,9 +1653,10 @@ function constructGoMenuItem(goMenu, beforeItem, url, title)
return menuitem;
}
function onGoMenuHidden()
function onGoMenuHidden(aEvent)
{
setTimeout(destroyGoMenuItems, 0, document.getElementById('goPopup'));
if (aEvent.target == aEvent.currentTarget)
setTimeout(destroyGoMenuItems, 0, document.getElementById('goPopup'));
}
function destroyGoMenuItems(goMenu) {
@@ -1680,8 +1681,11 @@ function destroyGoMenuItems(goMenu) {
}
}
function updateGoMenu(goMenu)
function updateGoMenu(aEvent, goMenu)
{
if (aEvent.target != aEvent.currentTarget)
return;
// In case the timer didn't fire.
destroyGoMenuItems(goMenu);