Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 815026: Bugzilla::Object cache should be cleared when an object is updated or removed from the database

Browse Source 
r=dkl, a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265144 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org
2013-12-17 06:03:20 +00:00
parent 9c1c4de307
commit a4c28f0a1d
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
8829
8830

16
mozilla/webtools/bugzilla/Bugzilla/Object.pm
View File

@@ -173,11 +173,21 @@ sub _cache_set {
Bugzilla->request_cache->{$cache_key} = $object;
}
sub _cache_remove {
my $class = shift;
my ($param) = @_;
$param->{cache} = 1;
my $cache_key = $class->cache_key($param)
|| return;
delete Bugzilla->request_cache->{$cache_key};
}
sub cache_key {
my $class = shift;
my ($param) = @_;
if (ref($param) && $param->{cache} && ($param->{id} || $param->{name})) {
return $class . ',' . ($param->{id} || $param->{name});
$class = blessed($class) if blessed($class);
return $class . ',' . ($param->{id} || $param->{name});
} else {
return;
}
@@ -451,6 +461,8 @@ sub update {
$self->audit_log(\%changes) if $self->AUDIT_UPDATES;
$dbh->bz_commit_transaction();
$self->_cache_remove({ id => $self->id });
$self->_cache_remove({ name => $self->name }) if $self->name;
if (wantarray) {
return (\%changes, $old_self);
@@ -469,6 +481,8 @@ sub remove_from_db {
$self->audit_log(AUDIT_REMOVE) if $self->AUDIT_REMOVES;
$dbh->do("DELETE FROM $table WHERE $id_field = ?", undef, $self->id);
$dbh->bz_commit_transaction();
$self->_cache_remove({ id => $self->id });
$self->_cache_remove({ name => $self->name }) if $self->name;
undef $self;
}