Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 382990 - Tree onkeypress should check for ctrl key (+ test to make sure this keeps working)

Browse Source 
r=mano@mozilla.com (Asaf Romano)
a=bzbarsky@mit.edu (Boris Zbarsky)


git-svn-id: svn://10.0.0.236/trunk@236211 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
gijskruitbosch%gmail.com
2007-09-18 14:26:06 +00:00
parent 73fdbddc36
commit b4f3205ddc
3 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
mozilla/toolkit/content/tests/widgets/Makefile.in
View File

@@ -47,6 +47,7 @@ include $(topsrcdir)/config/rules.mk
_TEST_FILES = test_bug360220.xul \
test_bug359754.xul \
test_bug365773.xul \
test_bug382990.xul \
test_closemenu_attribute.xul \
test_colorpicker_popup.xul \
test_deck.xul \

45
mozilla/toolkit/content/tests/widgets/test_bug382990.xul Normal file
View File

@@ -0,0 +1,45 @@
<?xml version="1.0"?>
<?xml-stylesheet href="chrome://global/skin" type="text/css"?>
<?xml-stylesheet href="/tests/SimpleTest/test.css" type="text/css"?>
<!--
https://bugzilla.mozilla.org/show_bug.cgi?id=382990
-->
<window title="Mozilla Bug 382990"
xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
onload="startThisTest()">
<script type="application/javascript" src="/MochiKit/packed.js" />
<script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"/>
<script type="application/javascript" src="/tests/SimpleTest/EventUtils.js"/>
<!-- test resuls are displayed in the html:body -->
<body xmlns="http://www.w3.org/1999/xhtml">
<a href="https://bugzilla.mozilla.org/show_bug.cgi?id=382990"
target="_blank">Mozilla Bug 382990</a>
</body>
<tree id="testTree" height="200px">
<treecols>
<treecol flex="1" label="Name" id="name"/>
</treecols>
<treechildren>
<treeitem><treerow><treecell label="a"/></treerow></treeitem>
<treeitem><treerow><treecell label="b"/></treerow></treeitem>
</treechildren>
</tree>
<!-- test code goes here -->
<script type="application/javascript"><![CDATA[
/** Test for Bug 382990 **/
SimpleTest.waitForExplicitFinish();
function startThisTest()
{
var treeElem = document.getElementById("testTree");
treeElem.view.selection.select(0);
treeElem.focus();
synthesizeKey("b", {ctrlKey: true});
ok(!treeElem.view.selection.isSelected(1), "Tree selection should not change for key events with ctrl pressed.");
SimpleTest.finish();
}
]]></script>
</window>

2
mozilla/toolkit/content/widgets/tree.xml
View File

@@ -820,7 +820,7 @@
}
else if (!this.disableKeyNavigation && event.charCode > 0 &&
!event.altKey && !this._isAccelPressed(event) &&
!event.metaKey) {
!event.metaKey && !event.ctrlKey) {
var l = this.keyNavigate(event);
if (l >= 0) {
this.view.selection.timedSelect(l, this._selectDelay);