Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Firebird bugs

Browse Source 
217195 (patch by Jesse Ruderman) - security hole in markLinkVisited (exploited with link.href usage)

219875 (patch by Mike Connor) - localize strings for provisional security UI in Advanced Options panel


git-svn-id: svn://10.0.0.236/trunk@171092 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
ben%bengoodger.com
2005-03-23 21:37:16 +00:00
parent c0c27bb30b
commit cef6d7f9ba
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mozilla/toolkit/content/contentAreaUtils.js
View File

@@ -105,10 +105,18 @@ function markLinkVisited(href, linkNode)
.getService(Components.interfaces.nsIGlobalHistory);
if (!globalHistory.isVisited(href)) {
globalHistory.addPage(href);
var oldHref = linkNode.href;
linkNode.href = "";
linkNode.href = oldHref;
}
var oldHref = linkNode.getAttribute("href");
if (typeof oldHref == "string") {
// Use setAttribute instead of direct assignment.
// (bug 217195, bug 187195)
linkNode.setAttribute("href", "");
linkNode.setAttribute("href", oldHref);
}
else {
// Converting to string implicitly would be a
// minor security hole (similar to bug 202994).
}
}
}
function urlSecurityCheck(url, doc)