Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 76498: QuickSearch: support comparison operators other than substring

Browse Source 
r=LpSolit a=justdave


git-svn-id: svn://10.0.0.236/trunk@265211 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
bzrmirror%bugzilla.org
2014-01-27 18:30:44 +00:00
parent c3c9d1dc34
commit e56fdbfbb3
3 changed files with 66 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
8894
8895

24
mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm
View File

@@ -103,6 +103,17 @@ use constant FIELD_OPERATOR => {
owner_idle_time => 'greaterthan',
};
# Mappings for operators symbols to support operators other than "substring"
use constant OPERATOR_SYMBOLS => {
':' => 'substring',
'=' => 'equals',
'!=' => 'notequals',
'>=' => 'greaterthaneq',
'<=' => 'lessthaneq',
'>' => 'greaterthan',
'<' => 'lessthan',
};
# We might want to put this into localconfig or somewhere
use constant PRODUCT_EXCEPTIONS => (
'row', # [Browser]
@@ -391,10 +402,11 @@ sub _handle_field_names {
# Generic field1,field2,field3:value1,value2 notation.
# We have to correctly ignore commas and colons in quotes.
my @field_values = _parse_line(':', 1, $or_operand);
if (scalar @field_values == 2) {
my @fields = _parse_line(',', 1, $field_values[0]);
my @values = _parse_line(',', 1, $field_values[1]);
foreach my $symbol (keys OPERATOR_SYMBOLS) {
my @field_values = parse_line($symbol, 1, $or_operand);
next unless scalar @field_values == 2;
my @fields = parse_line(',', 1, $field_values[0]);
my @values = parse_line(',', 1, $field_values[1]);
foreach my $field (@fields) {
my $translated = _translate_field_name($field);
# Skip and record any unknown fields
@@ -411,7 +423,9 @@ sub _handle_field_names {
$bug_status_set = 1;
}
foreach my $value (@values) {
my $operator = FIELD_OPERATOR->{$translated} || 'substring';
my $operator = FIELD_OPERATOR->{$translated}
|| OPERATOR_SYMBOLS->{$symbol}
|| 'substring';
# If the string was quoted to protect some special
# characters such as commas and colons, we need
# to remove quotes.

46
mozilla/webtools/bugzilla/template/en/default/pages/quicksearch.html.tmpl
View File

@@ -209,6 +209,52 @@
(<kbd>url</kbd> OR <kbd>location</kbd>) AND (<kbd>bar</kbd> OR
<kbd>field</kbd>) AND (NOT <kbd>focus</kbd>)</p>
</li>
<li>
The default operator, colon (:), performs a <strong>substring</strong>
match of the value. The following operators are supported:
<ul>
<li>
<strong>:</strong> (substring):<br>
<kbd><em>summary:foo</em></kbd> will search for [% terms.bugs %]
where the <kbd>summary</kbd> contains <kbd>foo</kbd>.
</li>
<li>
<strong>=</strong> (equals):<br>
<kbd><em>summary=foo</em></kbd> will search for [% terms.bugs %]
where the <kbd>summary</kbd> is exactly <kbd>foo</kbd>.
</li>
<li>
<strong>!=</strong> (notequals):<br>
<kbd><em>summary!=foo</em></kbd> will search for [% terms.bugs %]
where the <kbd>summary</kbd> is not <kbd>foo</kbd>.
</li>
<li>
<strong>&gt;</strong> (greaterthan):<br>
<kbd><em>creation_ts&gt;-2w</em></kbd> will search for [% terms.bugs %]
where that were created between two weeks ago and now, excluding [%
terms.bugs %] exactly two weeks old.
</li>
<li>
<strong>&gt;=</strong> (greaterthaneq):<br>
<kbd><em>creation_ts&gt;=-2w</em></kbd> will search for [% terms.bugs %]
where that were created between two weeks ago and now, including [%
terms.bugs %] exactly two weeks old.
</li>
<li>
<strong>&lt;</strong> (lessthan):<br>
<kbd><em>creation_ts&lt;-2w</em></kbd> will search for [% terms.bugs %]
where that were created more than two weeks ago, excluding [%
terms.bugs %] exactly two weeks old.
</li>
<li>
<strong>&lt;=</strong> (lessthaneq):<br>
<kbd><em>creation_ts&lt;=-2w</em></kbd> will search for [% terms.bugs %]
where that were created more than two weeks ago, including [%
terms.bugs %] exactly two weeks old.
</li>
</ul>
</li>
</ul>
<h2 id="shortcuts">Advanced Shortcuts</h2>