Fix for bug 554255 (Limit resource use to something sane). Patch by Peter Van der Beken <peterv@propagandism.org>, r=sicking, sr=jst, a1.9.0.next=dveditz
git-svn-id: svn://10.0.0.236/trunk@260878 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
@@ -178,7 +178,15 @@ txNodeSorter::sortNodeSet(txNodeSet* aNodes, txExecutionState* aEs,
|
||||
|
||||
// Create and set up memoryblock for sort-values and indexarray
|
||||
PRUint32 len = static_cast<PRUint32>(aNodes->size());
|
||||
void* mem = PR_Malloc(len * (sizeof(PRUint32) + mNKeys * sizeof(TxObject*)));
|
||||
|
||||
// Don't overflow when calculating the length of the sort buffer.
|
||||
PRUint32 itemSize = sizeof(PRUint32) + mNKeys * sizeof(TxObject*);
|
||||
if (mNKeys > (PR_UINT32_MAX - sizeof(PRUint32)) / sizeof(TxObject*) ||
|
||||
len >= PR_UINT32_MAX / itemSize) {
|
||||
return NS_ERROR_OUT_OF_MEMORY;
|
||||
}
|
||||
|
||||
void* mem = PR_Malloc(len * itemSize);
|
||||
NS_ENSURE_TRUE(mem, NS_ERROR_OUT_OF_MEMORY);
|
||||
|
||||
PRUint32* indexes = static_cast<PRUint32*>(mem);
|
||||
|
||||
Reference in New Issue
Block a user