Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't wrap E4X values in XPCWrappedJS since E4X objects have weird semantics, which cause us trouble both elsewhere in XPConnect, and even in the DOM code. bug 327697, r=brendan sr=shaver a=dveditz

Browse Source 
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_0_BRANCH@191913 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mrbkap%gmail.com
2006-03-07 19:28:10 +00:00
parent d09117a3ae
commit eabf36bec2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mozilla/js/src/xpconnect/src/xpcconvert.cpp
View File

@@ -1169,6 +1169,12 @@ XPCConvert::JSObject2NativeInterface(XPCCallContext& ccx,
}
// else...
// XXX E4X breaks the world. Don't try wrapping E4X objects!
// This hack can be removed (or changed accordingly) when the
// DOM <-> E4X bindings are complete, see bug 270553
if(JS_TypeOfValue(cx, OBJECT_TO_JSVAL(src)) == JSTYPE_XML)
return JS_FALSE;
// Does the JSObject have 'nsISupportness'?
// XXX hmm, I wonder if this matters anymore with no
// oldstyle DOM objects around.