Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 448815: Support pronouns for the "changed by" field in boolean charts

Browse Source 
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264313 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org
2012-10-09 23:15:48 +00:00
parent c5f95a7694
commit edc92b8772
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
8418
8419

15
mozilla/webtools/bugzilla/Bugzilla/Search.pm
View File

@@ -2154,6 +2154,15 @@ sub _contact_exact_group {
}
}
sub _get_user_id {
my ($self, $value) = @_;
if ($value =~ /^%\w+%$/) {
return pronoun($value, $self->_user);
}
return login_to_id($value, THROW_ERROR);
}
#####################################################################
# Search Functions
#####################################################################
@@ -2284,7 +2293,7 @@ sub _long_desc_changedby {
my $table = "longdescs_$chart_id";
push(@$joins, { table => 'longdescs', as => $table });
my $user_id = login_to_id($value, THROW_ERROR);
my $user_id = $self->_get_user_id($value);
$args->{term} = "$table.who = $user_id";
}
@@ -2380,7 +2389,7 @@ sub _work_time_changedby {
my $table = "longdescs_$chart_id";
push(@$joins, { table => 'longdescs', as => $table });
my $user_id = login_to_id($value, THROW_ERROR);
my $user_id = $self->_get_user_id($value);
$args->{term} = "$table.who = $user_id AND $table.work_time != 0";
}
@@ -2829,7 +2838,7 @@ sub _changedby {
|| ThrowCodeError("invalid_field_name", { field => $field });
my $field_id = $field_object->id;
my $table = "act_${field_id}_$chart_id";
my $user_id = login_to_id($value, THROW_ERROR);
my $user_id = $self->_get_user_id($value);
my $join = {
table => 'bugs_activity',
as => $table,