Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 556105: process_bug.cgi: Change the setting of normal global bug fields

Browse Source 
to use set_all
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260290 18797224-902f-48f8-a5cc-f745e15eee43
This commit is contained in:
mkanat%bugzilla.org
2010-05-13 06:35:02 +00:00
parent a762c7ce56
commit f9221f6206
2 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mozilla/webtools/bugzilla/.bzrrev
View File

@@ -1 +1 @@
7156
7157

29
mozilla/webtools/bugzilla/process_bug.cgi
View File

@@ -325,14 +325,23 @@ my @set_fields = qw(op_sys rep_platform priority bug_severity
deadline remaining_time estimated_time);
push(@set_fields, 'assigned_to') if !$cgi->param('set_default_assignee');
push(@set_fields, 'qa_contact') if !$cgi->param('set_default_qa_contact');
my %field_translation = (
bug_severity => 'severity',
rep_platform => 'platform',
short_desc => 'summary',
bug_file_loc => 'url',
);
my %set_all_fields;
foreach my $field_name (@set_fields) {
if (should_set($field_name)) {
my $param_name = $field_translation{$field_name} || $field_name;
$set_all_fields{$param_name} = $cgi->param($field_name);
}
}
my @custom_fields = Bugzilla->active_custom_fields;
my %methods = (
bug_severity => 'set_severity',
rep_platform => 'set_platform',
short_desc => 'set_summary',
bug_file_loc => 'set_url',
);
foreach my $b (@bug_objects) {
if (should_set('comment') || $cgi->param('work_time')) {
# Add a comment as needed to each bug. This is done early because
@@ -341,13 +350,7 @@ foreach my $b (@bug_objects) {
{ isprivate => scalar $cgi->param('commentprivacy'),
work_time => scalar $cgi->param('work_time') });
}
foreach my $field_name (@set_fields) {
if (should_set($field_name)) {
my $method = $methods{$field_name};
$method ||= "set_" . $field_name;
$b->$method($cgi->param($field_name));
}
}
$b->set_all(\%set_all_fields);
$b->reset_assigned_to if $cgi->param('set_default_assignee');
$b->reset_qa_contact if $cgi->param('set_default_qa_contact');