235 Commits

Author SHA1 Message Date
mozilla.mano%sent.com
6f8d04f432 Bug 357316 - More add/edit bookmark UI work. Changes listed on comment 15, r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221653 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-10 00:05:50 +00:00
mozilla.mano%sent.com
b86d5eeec8 Bug 329964 - Can't open a bookmark in the Web Panels sidebar in Places. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221531 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-08 09:29:19 +00:00
dietrich%mozilla.com
2b06e121b0 Bug 370013 Bookmarks toolbar folder should be a child of the bookmark menu folder, Bug 370020 No way to set an arbitrary folder as the bookmarks toolbar folder (r=mano)
git-svn-id: svn://10.0.0.236/trunk@221481 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 21:22:54 +00:00
mozilla.mano%sent.com
c674daa9dc Bug 371814 - undo-ing an item move in the organizer fails. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221422 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 01:29:27 +00:00
mozilla.mano%sent.com
a8acc179c1 Bug 372647- regression: bookmarkFeedURI annotation is not set on the children of a live bookmark. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221398 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-06 18:37:58 +00:00
mozilla.mano%sent.com
7c3bb47003 More UI-parity pieces for places-bookmarks. Changes include: 1) Implement New Bookmark and New Livemark commands and UI using the shared bookmark properties dialog (bug 365102). 2) Make New Folder command use the shared dialog as well. 3) Show dialog when adding a live-bookmark (bug 332965). 4) Hide most fields when adding a bookmark using 'Bookmark This Page...'. 5) defualt titles for each item type (bookmark/folder/livemark). 6) Changing the uri of a bookmark is now undoable. 7) Tidy up and document the dialog pseudo-API. patch on bug 357316, r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221352 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-05 22:39:21 +00:00
mozilla.mano%sent.com
f74b15c2a2 Copy the feed-uri rather than the site-uri when copying a live bookmark, patch on bug 342381. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@221328 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-05 19:47:55 +00:00
mozilla.mano%sent.com
f32d9976cc Bug 371668 - Disabled properties context menu-item for bookmarked history items. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@220924 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-26 14:09:53 +00:00
dietrich%mozilla.com
4140ac5778 Bug 360133 Bookmarks must be internally uniquely identifiable (r=mano, sspitzer)
git-svn-id: svn://10.0.0.236/trunk@220909 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-26 00:54:36 +00:00
mozilla.mano%sent.com
12aee7ec9a Bug 370959 - places frontend code cleanup. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@220566 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-20 00:51:31 +00:00
mozilla.mano%sent.com
55c4ba3bbe Bug 364644 - Re-enable livemark-reload functionality. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@220557 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-19 20:12:25 +00:00
jminta%gmail.com
58727fc239 Bug 370329 Only do batch transactions when we really have a lot of transactions, r=mano
git-svn-id: svn://10.0.0.236/trunk@220103 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-14 02:08:26 +00:00
mozilla.mano%sent.com
d0001df1fe Bug 366372 - 'Get Info' (Properties) command should be disabled for items under a live-bookmark folder. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@220084 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-13 22:11:35 +00:00
mozilla.mano%sent.com
397fe43d36 Bug 369407 - Make the history sidebar use the shared places context menu. As part of that: 1) Add context menu for multiple-items selection 2) Remove the Expand/Collapse menu-item. 3) Replace the 'Copy Link Location' menu-item with the generic 'Copy' menu-item, which also copies the node title. r=sspitzer, ui-r=mconnor.
git-svn-id: svn://10.0.0.236/trunk@219915 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-09 22:17:37 +00:00
mozilla.mano%sent.com
4e4eab18f2 Copy the security checks for history items to placescontroller/utils, r=sspitzer (patch on bug 362292).
git-svn-id: svn://10.0.0.236/trunk@219522 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-05 20:38:52 +00:00
mozilla.mano%sent.com
e6670fd427 Bug 369311 - Typo in buildSelectionMetadata breaks the places context menu in certain conditions. r=gavin.
git-svn-id: svn://10.0.0.236/trunk@219480 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-05 00:28:27 +00:00
mozilla.mano%sent.com
36cdb865b5 Bug 369222 - Javascript error when opening the context menu for the empty area (i.e. root node) in the places toolbar. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@219474 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-04 19:23:00 +00:00
mozilla.mano%sent.com
eb44fa2328 Bug 342381 - Copying a live bookmark should put the feed url on the clipboard. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@219213 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-31 02:40:18 +00:00
mozilla.mano%sent.com
7b84683c19 Bug 367989 - metadata about node annotations is no longer set for uri nodes. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218910 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-25 18:52:15 +00:00
mozilla.mano%sent.com
7c0426bca4 Bug 367187 - Places context menu fx2-parity. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218732 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-21 23:22:52 +00:00
mozilla.mano%sent.com
b3083a3b14 Bug 365538 - 'Move Bookmark(s)' UI in Places Organizer. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218092 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-09 23:00:23 +00:00
mozilla.mano%sent.com
4a73f4368c Bug 366474 - rootNodeIsSelected is not reliable for the menu view. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218090 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-09 22:48:50 +00:00
mozilla.mano%sent.com
999a4370c1 Bug 366372 - 'Get Info' (properteis) should be disabled for items under a live-bookmark folder. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218029 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-08 23:54:05 +00:00
mozilla.mano%sent.com
4383542683 Bug 366174 - Open in Tabs context menu item is enabled for empty folders. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218025 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-08 23:03:20 +00:00
mozilla.mano%sent.com
9ca4a35a24 Bug 366027 - Redo command is broken once a remove-separator command is undone. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217910 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-07 00:46:55 +00:00
mozilla.mano%sent.com
d555426b0e Bug 365981 - Places XUL cleanup. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217818 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-05 11:45:15 +00:00
mozilla.mano%sent.com
ff1592d55c Bug 365171 - Bug context menu delete of personal toolbar bookmark can delete history item if focused. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217530 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-28 22:56:59 +00:00
mozilla.mano%sent.com
ced59144f3 Use the right array lenght in the fix for bug 365100.
git-svn-id: svn://10.0.0.236/trunk@217527 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-28 21:26:11 +00:00
mozilla.mano%sent.com
cbc4777865 Bug 365100 - 'Open in Tabs' doesn't work in the left pane of the organizer. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217482 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 21:03:02 +00:00
mozilla.mano%sent.com
64e247a4c3 Bug 334451 - Places Organizer: places-list tree should not list bookmark items. This also fixes the selectBookmark dialog bustage from bug 359462. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217440 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 00:36:35 +00:00
mozilla.mano%sent.com
b9299566db Bug 329949 - browser.tabs.loadBookmarksInBackground is ignored in places views (histrory sidebar, bookmarks toolbar etc.). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217437 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 20:26:38 +00:00
mozilla.mano%sent.com
e7ccd5bf3c Bug 365002 - newFolder/Separator methods should not try to focus the controller's view. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217414 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 01:57:23 +00:00
mozilla.mano%sent.com
da56f8b8df Bug 336990 - Choosing delete on bookmarks toolbar deletes everything there indeed (this should only affect --enable-places-bookmarks builds). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217413 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 01:54:51 +00:00
mozilla.mano%sent.com
6235546314 Bug 359462 - Redesign PlacesController interaction with places views (this makes various edit command work in the places-based history sidebar). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217328 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-22 00:00:21 +00:00
sayrer%gmail.com
6dacac1bce Bug 358946. Let the places unit tests pass. r=sspitzer,mano
git-svn-id: svn://10.0.0.236/trunk@216987 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-14 17:28:52 +00:00
sspitzer%mozilla.org
8412607c42 fix for bug #356487
make MOZ_PLACES (if enabled) only build the places based history UI, use MOZ_PLACES_BOOKMARKS to turn off the places based bookmarks UI.

also addresses bugs:

bug #330923:  "View -> Sidebar menu" is empty if you build with places
bug #355738:  implement history sidebar on top of places backend
bug #356175:  hook up the history menu to the places backend
bug #356453:  add back "Clear Private Data" menu item
bug #356630:  add back "History | Show in Sidebar" menu item
bug #356631:  remove "search in history" and "view all history" menu items
bug #357301:  add back history and bookmark sidebar toolbar button items, remove places toolbar button
bug #358831:  history sidebar, right mouse button click should not expand / collapse item

r=dietrich, r=gavin


git-svn-id: svn://10.0.0.236/trunk@214697 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-04 04:48:06 +00:00
sayrer%gmail.com
057ed191f6 Bug 353434. Remove C++ feed parsing for livemarks on trunk (places). r=dietrich
git-svn-id: svn://10.0.0.236/trunk@213839 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-19 02:24:30 +00:00
sspitzer%mozilla.org
12df9d9a2e fix for bug #342930: "You have asked to open [lots of] tabs at once" should read "You are about to open..."
backporting the fix from the MOZILLA_1_8_BRANCH to work on the trunk (both with places enabled and without)

r=dietrich, original patch r=mconnor, ui-r=beltzner


git-svn-id: svn://10.0.0.236/trunk@213472 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-10 23:19:01 +00:00
pkasting%google.com
9b70e7b374 Bug 321973: Make "Bookmark This Link" work.
r=jhughes
sr=beng


git-svn-id: svn://10.0.0.236/trunk@208954 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-01 00:33:23 +00:00
gavin%gavinsharp.com
27872df3d4 Bug 346447: loadFolderAndReplace=false ignores "loading" tabs, patch by Pablo Greco <pablo@fliagreco.com.ar>, r=mano
git-svn-id: svn://10.0.0.236/trunk@206773 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 23:01:32 +00:00
sspitzer%mozilla.org
451440563b fix for bug #344040: when warning on "opening too many tabs", only count non-deleted bookmarks (and not folders or separators)
r=ben


git-svn-id: svn://10.0.0.236/trunk@203434 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-22 06:52:51 +00:00
gavin%gavinsharp.com
0eec265eab Bug 343958: fix strict warnings in controller.js, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie
git-svn-id: svn://10.0.0.236/trunk@201844 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-10 22:48:48 +00:00
sspitzer%mozilla.org
17b07f233e fix for bug #340966, regression, "node QI Failed When middle clicking a bookmark"
also address another scenario of bug #333734, "Protect against opening too many tabs at once"

r=ben


git-svn-id: svn://10.0.0.236/trunk@200059 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-15 22:58:34 +00:00
sspitzer%mozilla.org
e89fe2a455 supplimental checkin for bug #333734, protect (warn) against opening too many tabs at once. ugh.
git-svn-id: svn://10.0.0.236/trunk@199584 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 08:04:10 +00:00
sspitzer%mozilla.org
3a41db1475 follow-up checkin for #333734, fix coding style per ben.
git-svn-id: svn://10.0.0.236/trunk@199583 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:58:20 +00:00
sspitzer%mozilla.org
3cd53db8af fix for bug #333734. protect (warn) against opening too many tabs at once.
r=ben, UI and strings r=beltzner


git-svn-id: svn://10.0.0.236/trunk@199582 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:53:12 +00:00
myk%mozilla.org
e3fb608fb9 Initial support for microsummaries via a service and integration into the bookmarks UI.
bug=334471
r=brettw
a=ben for the branch


git-svn-id: svn://10.0.0.236/trunk@196058 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-05 22:46:57 +00:00
beng%bengoodger.com
34fe8b6a16 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194665 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-19 03:34:26 +00:00
joe%retrovirus.com
d0895ce7be Removes the history item mode for the (Bookmark) Properties dialog, which
just showed disabled title and URI fields.  The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.

bug=330876
r/sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194575 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-18 01:49:10 +00:00
beng%bengoodger.com
9776ca9ad4 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
git-svn-id: svn://10.0.0.236/trunk@194357 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 22:51:36 +00:00