Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
218,801 Commits 3,986 Branches 0 Tags
Commit Graph

235 Commits

Author SHA1 Message Date
joe%retrovirus.com
60817e663a Resubmitting this patch, which adds a editing for livemark URIs as well 
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194326 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-13 17:20:31 +00:00
brettw%gmail.com
c411b948c4 Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks" 
git-svn-id: svn://10.0.0.236/trunk@194323 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-13 16:40:12 +00:00
gavin%gavinsharp.com
0f60b6f38b Bug 332888: JS warning: variable folderId hides argument, r=ben 
git-svn-id: svn://10.0.0.236/trunk@194238 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-12 18:23:33 +00:00
beng%bengoodger.com
0b2c084a31 329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@194025 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-10 19:26:01 +00:00
joe%retrovirus.com
a495b02fad Backing out patch from bug 330063 to see if it's responsible for the 
branch balsa allocation increases, and if so, fix before resubmitting.


git-svn-id: svn://10.0.0.236/trunk@193946 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-08 17:58:56 +00:00
joe%retrovirus.com
7743954cf5 * Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog 
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193764 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-06 23:29:46 +00:00
joe%retrovirus.com
abc6a9eccd Implements "Bookmark All Tabs..." for Places. (Also fixes a small error 
when undoing aggregate transactions.)

bug=330929
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193476 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-04 01:26:58 +00:00
darin%meer.net
abbff9281c fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng 
git-svn-id: svn://10.0.0.236/trunk@193469 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-04 00:32:33 +00:00
beng%bengoodger.com
142a6e54ee 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193467 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-04 00:13:58 +00:00
roc+%cs.cmu.edu
e9fd34c810 Bug 331522. By default, do not allow keyword searches when navigating to URLs; modify browser UI code to enable keyword searches only on selected URL input mechanisms (e.g., typed into the URL bar). r+sr=darin,r=mconnor 
git-svn-id: svn://10.0.0.236/trunk@193458 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-03 23:17:51 +00:00
beng%bengoodger.com
8e71d880a9 331905 - pasted folders/items are inserted at the wrong level in the bookmarks hierarchy. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193353 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-31 22:42:21 +00:00
joe%retrovirus.com
cb00bb5c6e Convert all the DB-modifying operations in the Bookmark Properties to use 
transactions so that they can be undone.  (The "change URI" is the only one
that's not transactionized yet, because it needs deeper work, cf. bug 331655)

bug=326321
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193288 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-31 00:34:03 +00:00
beng%bengoodger.com
70f81c13c5 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193145 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-28 19:59:26 +00:00
beng%bengoodger.com
80748c607e 323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193093 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-28 00:54:10 +00:00
beng%bengoodger.com
714620c65c 324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS) 
git-svn-id: svn://10.0.0.236/trunk@192968 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-25 00:46:28 +00:00
annie.sullivan%gmail.com
9316eae604 Bug 329743: fixes dropmarker icon not showing up on places toolbar folders on mac. 
Patch by Pam Greene <pamg.bugs@gmail.com>
r=annie.sullivan@gmail.com sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192850 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-23 16:30:27 +00:00
joe%retrovirus.com
50f2b58118 * Moved changeBookmarkURI functionality from controller.js into 
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
  intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
  intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
  has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546

bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com


git-svn-id: svn://10.0.0.236/trunk@192839 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-23 06:26:23 +00:00
beng%bengoodger.com
e5d1d8cd9e 329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@192826 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-23 00:54:35 +00:00
joe%retrovirus.com
b35399cf15 This submission is a roll-up of three patches developed & approved during 
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names

r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192752 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-22 03:36:41 +00:00
beng%bengoodger.com
dfde20d73e 329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@192511 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-17 02:02:36 +00:00
annie.sullivan%gmail.com
78ce903b68 Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130 
git-svn-id: svn://10.0.0.236/trunk@192438 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-15 19:59:09 +00:00
joe%retrovirus.com
8afe1d3f15 Moved Ben's JavaScript ASSERT function to be NS_ASSERT in 
toolkit/content/debug.js

debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.

NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true.  The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions.  To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.

bug=327349
r=darin@meer.net, gavin.sharp@gmail.com


git-svn-id: svn://10.0.0.236/trunk@192291 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-14 01:57:26 +00:00
beng%bengoodger.com
61e70249c5 329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@192184 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-10 23:48:40 +00:00
joe%retrovirus.com
b5ef892f4b Changes to bookmark properties dialog: 
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
  yielding layout and accessibility improvements
* Switched to using standard dialog buttons

bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com


git-svn-id: svn://10.0.0.236/trunk@192153 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-10 17:37:22 +00:00
beng%bengoodger.com
19a6ee894c 329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com 
git-svn-id: svn://10.0.0.236/trunk@192112 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-09 22:03:26 +00:00
beng%bengoodger.com
71f043ee27 329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@192043 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-09 02:09:28 +00:00
annie.sullivan%gmail.com
80e6be148f Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org 
git-svn-id: svn://10.0.0.236/trunk@191937 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-07 23:20:46 +00:00
beng%bengoodger.com
30baedb921 329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com 
git-svn-id: svn://10.0.0.236/trunk@191903 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-07 18:25:43 +00:00
joe%retrovirus.com
fb37866416 * Allows the user to access Bookmark Properties dialog from context menus. 
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js

NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.

bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com


git-svn-id: svn://10.0.0.236/trunk@191866 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-07 00:52:35 +00:00
annie.sullivan%gmail.com
c53df84f97 Adds menuitem for Open In Tabs. 
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034


git-svn-id: svn://10.0.0.236/trunk@191751 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-04 01:12:05 +00:00
annie.sullivan%gmail.com
a849dcc264 Fixes problems with bookmark menus and toolbarbuttons not working correctly on mac. bug=327036 r=ben@mozilla.org 
git-svn-id: svn://10.0.0.236/trunk@191046 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-23 18:30:40 +00:00
annie.sullivan%gmail.com
6c4da27e08 Checking in patch by mossop@blueprintit.co.uk to allow middle click to open links in tabs. bug=325781 sr=beng 
git-svn-id: svn://10.0.0.236/trunk@190409 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-17 22:58:41 +00:00
annie.sullivan%gmail.com
25c5de86b2 Fixed drag and drop support for toolbars and menus. Added lots more visual feedback when dragging and dropping. 
bug=318052 r=beng


git-svn-id: svn://10.0.0.236/trunk@190372 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-17 18:31:06 +00:00
beng%bengoodger.com
5d6a68fdd0 326598 - tree D&D massively broken. r=annie.sullivan@gmail.com. checked in on the branch earlier, checking in now to the trunk. 
git-svn-id: svn://10.0.0.236/trunk@190001 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-14 21:36:04 +00:00
beng%bengoodger.com
9143b15116 324948 - should not be able to do edit operations on immutable containers (delete, paste, cut). Make sure we check if a container has readonly children, or the folder itself (if it is a bookmark folder) is readonly before enabling commands for cut, copy and paste. Also assert that activeView is non-null, for safety. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@189515 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-09 21:32:59 +00:00
beng%bengoodger.com
d96e4e9ac5 320655 - changing the history view displayed should also update the sorting r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@189496 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-09 19:29:40 +00:00
beng%bengoodger.com
900d71e4f3 326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@189385 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-08 01:53:22 +00:00
bryner%brianryner.com
be3171d190 Add support for bookmark separators (bug 320261). r=brettw, ben. 
git-svn-id: svn://10.0.0.236/trunk@189381 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-08 01:10:57 +00:00
brettw%gmail.com
41ced7c321 Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode. 
git-svn-id: svn://10.0.0.236/trunk@189277 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-07 01:57:53 +00:00
annie.sullivan%gmail.com
aa2f410a8c bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons 
git-svn-id: svn://10.0.0.236/trunk@188636 18797224-902f-48f8-a5cc-f745e15eee43
 2006-02-01 02:14:42 +00:00
beng%bengoodger.com
a116bde39d 317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'. 
git-svn-id: svn://10.0.0.236/trunk@188580 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-31 18:00:06 +00:00
brettw%gmail.com
e1d3607693 [for joe@retrovirus.com] Bug 324743, r=brettw. Result roots are closed by default. 
git-svn-id: svn://10.0.0.236/trunk@188540 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-31 03:05:07 +00:00
annie.sullivan%gmail.com
3728358cf8 Fixes to toolbar and menu to work with new history backend. 
r=brettw sr=ben bug=209804


git-svn-id: svn://10.0.0.236/trunk@188353 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-27 18:30:51 +00:00
brettw%gmail.com
1446e8ae8d Bug 323492 r=bryner,beng Places history result node refactor, dynamic updates, performance improvements. 
git-svn-id: svn://10.0.0.236/trunk@188076 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-24 01:24:15 +00:00
annie.sullivan%gmail.com
aeb3c4e955 Fixed JavaScript errors which were breaking copy/paste/delete. 
bug=324056 r=beng


git-svn-id: svn://10.0.0.236/trunk@187898 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-20 17:03:45 +00:00
beng%bengoodger.com
cdf23dfbfb save selection across delete operations (not done automatically by the view object)... , also restyle parts of the band across the top of the places view to make the content clearer. 
git-svn-id: svn://10.0.0.236/trunk@187732 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-18 00:11:25 +00:00
beng%bengoodger.com
bb14f02244 rejigger places UI a bit, add a title bar across the top of the places view, adjust the default entries in the listbox, etc. also fix icons for generic queries and generic non-favicon pages. r=brettw for changes to the cpp. NPOB 
git-svn-id: svn://10.0.0.236/trunk@187587 18797224-902f-48f8-a5cc-f745e15eee43
 2006-01-13 20:47:18 +00:00
brettw%gmail.com
8f9c380102 Bug 320422 r=annie.sullivan: Rename nav-history/nsINavHistory to nav-history-service/nsINavHistoryService 
git-svn-id: svn://10.0.0.236/trunk@186143 18797224-902f-48f8-a5cc-f745e15eee43
 2005-12-16 00:40:48 +00:00
annie.sullivan%gmail.com
8e7ccad57f Added nsIBookmarksContainer interface which allows custom bookmarks types. 
Implemented nsILivemarksService as a nsIBookmarksContainer.
bug=317837 r=beng sr=bryner


git-svn-id: svn://10.0.0.236/trunk@186125 18797224-902f-48f8-a5cc-f745e15eee43
 2005-12-15 20:56:18 +00:00
brettw%gmail.com
6e24003bbd Bug 317840, r=ben Delete history itens frontend 
git-svn-id: svn://10.0.0.236/trunk@186116 18797224-902f-48f8-a5cc-f745e15eee43
 2005-12-15 17:53:31 +00:00