Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
123,840 Commits 3,986 Branches 0 Tags
Commit Graph

123840 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
edburns%acm.org
18536df439 SECTION: Changes 
M build-tests.xml

- changes to make unit tests run again.

M build.xml

- updated version

- create the services definition for the webclient implementation

M classes_spec/org/mozilla/webclient/BrowserControlCanvas.java
M classes_spec/org/mozilla/webclient/BrowserControlImpl.java

- temporary hacks until we have everything migrated to the new package
  structure.

M classes_spec/org/mozilla/webclient/BrowserControlFactory.java

- Make this class be a shim to the implementation specific instance.

A classes_spec/org/mozilla/webclient/BrowserControlFactoryInterface.java

- Interface to be implemented by the webclient implementor

A classes_spec/org/mozilla/webclient/impl/BrowserControlFactoryImpl.java

- concrete implementation of BrowserControlFactoryInterface

A test/automated/src/classes/org/mozilla/webclient/BrowserControlFactoryTest.java

- test that the factory can be instantiated.

M test/automated/src/classes/org/mozilla/webclient/WebclientTestCase.java

- Make sure we have our bin dir set.


Index: build-tests.xml
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/build-tests.xml,v
retrieving revision 1.1
diff -u -r1.1 build-tests.xml
--- build-tests.xml	1 Oct 2002 00:39:18 -0000	1.1
+++ build-tests.xml	6 Sep 2003 06:22:05 -0000
@@ -3,7 +3,7 @@
  SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
 -->
 
-<project name="Webclient Unit Tests" default="test.local" basedir=".">
+<project name="Webclient Unit Tests" default="run.test" basedir=".">
 
 <!--
         This is a generic build.xml file for Ant that is used to run the
@@ -75,7 +75,7 @@
 
     <path id="test.classpath">
       <pathelement location="${junit.jar}"/>
-      <pathelement location="${build.home}/classes"/>
+      <pathelement location="${build.home}"/>
       <pathelement location="${out.test.dir}/classes"/>
     </path>
 
@@ -87,6 +87,8 @@
 -->
     <target name="compile.test">
 
+        <echo message="${build.home}"/>
+
         <mkdir  dir="${out.test.dir}/classes"/>
 
         <javac srcdir="${src.test.dir}"
@@ -125,6 +127,7 @@
             <jvmarg value="-Djava.library.path=${myenv.MOZILLA_FIVE_HOME}:${myenv.MOZILLA_FIVE_HOME}/components"/>
             <jvmarg value="-DNSPR_LOG_MODULES=${myenv.NSPR_LOG_MODULES}"/>
             <jvmarg value="-DNSPR_LOG_FILE=${myenv.NSPR_LOG_FILE}"/>
+            <jvmarg value="-DBROWSER_BIN_DIR=${myenv.MOZILLA_FIVE_HOME}"/>
             <jvmarg line="${debug.jvm.args}"/>
 
 
@@ -132,7 +135,11 @@
 
             <formatter type="plain" usefile="false"/>
 
+            <test name="org.mozilla.webclient.BrowserControlFactoryTest"/>
+<!-- non-running tests 
+
             <test name="org.mozilla.webclient.wrapper_native.gtk.TestGtkBrowserControlCanvas"/>
+-->
 
         </junit>
 
Index: build.xml
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/build.xml,v
retrieving revision 1.15
diff -u -r1.15 build.xml
--- build.xml	9 Jun 2003 20:05:33 -0000	1.15
+++ build.xml	6 Sep 2003 06:22:06 -0000
@@ -30,7 +30,7 @@

   <property name="Name" value="webclient"/>
   <property name="name" value="webclient"/>
-  <property name="version" value="20020916"/>
+  <property name="version" value="20030906"/>

 <!-- ************ Per user local properties ******************************* -->

@@ -85,8 +85,12 @@

       <include name="org/mozilla/webclient/*"/>
       <include name="org/mozilla/webclient/wrapper_native/*"/>
+      <include name="org/mozilla/webclient/impl/**"/>
       <include name="org/mozilla/webclient/test/*"/>
     </javac>
+
+    <mkdir dir="${build.home}/META-INF/services"/>
+    <echo file="${build.home}/META-INF/services/org.mozilla.webclient.BrowserControlFactoryInterface">org.mozilla.webclient.impl.BrowserControlFactoryImpl</echo>

   </target>

Index: classes_spec/org/mozilla/webclient/BrowserControlCanvas.java
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/classes_spec/org/mozilla/webclient/BrowserControlCanvas.java,v
retrieving revision 1.5
diff -u -r1.5 BrowserControlCanvas.java
--- classes_spec/org/mozilla/webclient/BrowserControlCanvas.java	9 Apr 2003 17:42:30 -0000	1.5
+++ classes_spec/org/mozilla/webclient/BrowserControlCanvas.java	6 Sep 2003 06:22:06 -0000
@@ -114,7 +114,8 @@

 } // BrowserControlCanvas() ctor

-protected void initialize(BrowserControl controlImpl)
+// PENDING(edburns): make this protected again
+public void initialize(BrowserControl controlImpl)
 {
     ParameterCheck.nonNull(controlImpl);
     webShell = controlImpl;
Index: classes_spec/org/mozilla/webclient/BrowserControlFactory.java
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/classes_spec/org/mozilla/webclient/BrowserControlFactory.java,v
retrieving revision 1.7
diff -u -r1.7 BrowserControlFactory.java
--- classes_spec/org/mozilla/webclient/BrowserControlFactory.java	1 Oct 2002 00:39:20 -0000	1.7
+++ classes_spec/org/mozilla/webclient/BrowserControlFactory.java	6 Sep 2003 06:22:06 -0000
@@ -35,22 +35,38 @@
 import java.io.File;
 import java.io.FileNotFoundException;

-/**
- *
- *  <B>BrowserControlFactory</B> creates concrete instances of BrowserControl
-
- * <B>Lifetime And Scope</B> <P>
+import java.io.BufferedReader;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.util.HashMap;
+import java.util.Properties;

- * This is a static class, it is neven instantiated.

+/**
+ *
+ *  <p><B>BrowserControlFactory</B> uses a discovery algorithm to find
+ *  an implementation of {@link BrowserControlFactoryInterface}.  All of
+ *  the public static methods in this class simply call through to this
+ *  implemenatation instance.</p>
+ *
+ * <p>The discovery mechanism used is to look try to load a resource
+ * called
+ * <code>META-INF/services/org.mozilla.webclient.BrowserControlFactoryInterface</code>.
+ * If the resource is found, interpret it as a <code>Properties</code>
+ * file and read out its first line.  Interpret the first line as the
+ * fully qualified class name of a class that implements {@link
+ * BrowserControlFactoryInterface}.  The named class must have a public
+ * no-arg constructor.</p>
+ *
  *
  * @version $Id: BrowserControlFactory.java,v 1.7 2002/10/01 00:39:20 edburns%acm.org Exp $
  *
- * @see	org.mozilla.webclient.test.EmbeddedMozilla
-
+ *
  */

-public class BrowserControlFactory extends Object
+public class BrowserControlFactory extends Object
 {
 //
 // Protected Constants
@@ -60,24 +76,13 @@
 // Class Variables
 //

-    private static boolean appDataHasBeenSet = false;
-    private static Class browserControlCanvasClass = null;
-    private static String platformCanvasClassName = null;
-    private static String browserType = null;
-
-//
-// Instance Variables
-//
-
-// Attribute Instance Variables
-
-// Relationship Instance Variables
+private static BrowserControlFactoryInterface instance = null;

 //
 // Constructors and Initializers
 //

-public BrowserControlFactory()
+private BrowserControlFactory()
 {
     Assert.assert_it(false, "This class shouldn't be constructed.");
 }
@@ -88,179 +93,97 @@

 public static void setAppData(String absolutePathToNativeBrowserBinDir) throws FileNotFoundException, ClassNotFoundException
 {
-    BrowserControlFactory.setAppData(BrowserControl.BROWSER_TYPE_NATIVE, absolutePathToNativeBrowserBinDir);
+    getInstance().setAppData(BrowserControl.BROWSER_TYPE_NATIVE, absolutePathToNativeBrowserBinDir);
 }

-
-    /**
-
-     * This method is used to set per-application instance data, such as
-     * the location of the browser binary.
-
-     * @param myBrowserType.  Either "native" or "nonnative"
-
-     * @param absolutePathToNativeBrowserBinDir the path to the bin dir
-     * of the native browser, including the bin.  ie:
-     * "D:\Projects\mozilla\dist\win32_d.obj\bin"
-
-     */
-
 public static void setAppData(String myBrowserType, String absolutePathToNativeBrowserBinDir) throws FileNotFoundException, ClassNotFoundException
 {
-    browserType = myBrowserType;
-    if (!appDataHasBeenSet) {
-        // figure out the correct value for platformCanvasClassName
-        if (browserType.equals(BrowserControl.BROWSER_TYPE_NON_NATIVE)) {
-            platformCanvasClassName = "org.mozilla.webclient.wrapper_nonnative.JavaBrowserControlCanvas";
-        }
-        else {
-            ParameterCheck.nonNull(absolutePathToNativeBrowserBinDir);
-
-            // verify that the directory exists:
-            File binDir = new File(absolutePathToNativeBrowserBinDir);
-            if (!binDir.exists()) {
-                throw new FileNotFoundException("Directory " + absolutePathToNativeBrowserBinDir + " is not found.");
-            }
-
-            // This hack is necessary for Sun Bug #4303996
-            java.awt.Canvas c = new java.awt.Canvas();
-            platformCanvasClassName = determinePlatformCanvasClassName();
-        }
-        // end of figuring out the correct value for platformCanvasClassName
-        if (platformCanvasClassName != null) {
-            browserControlCanvasClass = Class.forName(platformCanvasClassName);
-        }
-        else {
-            throw new ClassNotFoundException("Could not determine BrowserControlCanvas class to load\n");
-        }
-
-        try {
-            BrowserControlImpl.appInitialize(browserType, absolutePathToNativeBrowserBinDir);
-        }
-        catch (Exception e) {
-            throw new ClassNotFoundException("Can't initialize native browser: " +
-                                             e.getMessage());
-        }
-        appDataHasBeenSet = true;
-    }
+    getInstance().setAppData(myBrowserType, absolutePathToNativeBrowserBinDir);
 }

 public static void appTerminate() throws Exception
 {
-    BrowserControlImpl.appTerminate();
+    getInstance().appTerminate();
 }

 public static BrowserControl newBrowserControl() throws InstantiationException, IllegalAccessException, IllegalStateException
 {
-    if (!appDataHasBeenSet) {
-        throw new IllegalStateException("Can't create BrowserControl instance: setAppData() has not been called.");
-    }
-    Assert.assert_it(null != browserControlCanvasClass);
-
-    BrowserControlCanvas newCanvas = null;
-    BrowserControl result = null;
-    newCanvas = (BrowserControlCanvas) browserControlCanvasClass.newInstance();
-    if (null != newCanvas &&
-        null != (result = new BrowserControlImpl(browserType, newCanvas))) {
-        newCanvas.initialize(result);
-    }
-
+    BrowserControl result = null;
+    result = getInstance().newBrowserControl();
     return result;
 }

-/**
-
- * BrowserControlFactory.deleteBrowserControl is called with a
- * BrowserControl instance obtained from
- * BrowserControlFactory.newBrowserControl.  This method renders the
- * argument instance completely un-usable.  It should be called when the
- * BrowserControl instance is no longer needed.  This method simply
- * calls through to the non-public BrowserControlImpl.delete() method.
-
- * @see org.mozilla.webclient.ImplObject#delete
-
- */
-
 public static void deleteBrowserControl(BrowserControl toDelete)
 {
-    ParameterCheck.nonNull(toDelete);
-    ((BrowserControlImpl)toDelete).delete();
+    getInstance().deleteBrowserControl(toDelete);
 }

 //
-// General Methods
-//
-
-/**
+// helper methods
+//

- * Called from setAppData() in the native case.  This method simply
- * figures out the proper name for the class that is the
- * BrowserControlCanvas.
-
- * @return  "org.mozilla.webclient.wrapper_native.win32.Win32BrowserControlCanvas" or "org.mozilla.webclient.wrapper_native.gtk.GtkBrowserControlCanvas"
-
- */
-
-private static String determinePlatformCanvasClassName()
+protected static BrowserControlFactoryInterface getInstance()
 {
-    String result = null;
-    // cause the native library to be loaded
-    // PENDING(edburns): do some magic to determine the right kind of
-    // MozWebShellCanvas to instantiate
-
-    // How about this:
-    // I try loading sun.awt.windows.WDrawingSurfaceInfo. If it doesn't
-    // load, then I try loading sun.awt.motif.MDrawingSufaceInfo. If
-    // none loads, then I return a error message.
-    // If you think up of a better way, let me know.
-    // -- Mark
-    // Here is what I think is a better way: query the os.name property.
-    // This works in JDK1.4, as well.
-    // -- edburns
+    if (null != instance) {
+        return instance;
+    }

-    String osName = System.getProperty("os.name");
-
-    if (null != osName) {
-       if (-1 != osName.indexOf("indows")) {
-           result = "org.mozilla.webclient.wrapper_native.win32.Win32BrowserControlCanvas";
-       }
-       else {
-           result = "org.mozilla.webclient.wrapper_native.gtk.GtkBrowserControlCanvas";
-       }
+    ClassLoader classLoader = Thread.currentThread().getContextClassLoader();
+    if (classLoader == null) {
+        throw new RuntimeException("Context ClassLoader");
     }

-    return result;
-}
-
-// ----UNIT_TEST_START
-
-//
-// Test methods
-//
-
-public static void main(String [] args)
-{
-    System.out.println("doing asserts");
-    Assert.setEnabled(true);
-    Log.setApplicationName("BrowserControlFactory");
-    Log.setApplicationVersion("0.0");
-    Log.setApplicationVersionDate("$Id: BrowserControlFactory.java,v 1.7 2002/10/01 00:39:20 edburns%acm.org Exp $");
-
-    BrowserControlCanvas canvas = null;
-    BrowserControl control = null;
+    BufferedReader reader = null;
+    InputStream stream = null;
+    String
+        className = null,
+        resourceName = "META-INF/services/org.mozilla.webclient.BrowserControlFactoryInterface";
     try {
-        BrowserControlFactory.setAppData("nonnative", args[0]);
-        control = BrowserControlFactory.newBrowserControl();
-        Assert.assert_it(control != null);
-        canvas = (BrowserControlCanvas) control.queryInterface("webclient.BrowserControlCanvas");
-        Assert.assert_it(canvas != null);
+        stream = classLoader.getResourceAsStream(resourceName);
+        if (stream != null) {
+            // Deal with systems whose native encoding is possibly
+            // different from the way that the services entry was created
+            try {
+                reader =
+                    new BufferedReader(new InputStreamReader(stream,
+                                                             "UTF-8"));
+            } catch (UnsupportedEncodingException e) {
+                reader = new BufferedReader(new InputStreamReader(stream));
+            }
+            className = reader.readLine();
+            reader.close();
+            reader = null;
+            stream = null;
+        }
+    } catch (IOException e) {
+    } catch (SecurityException e) {
+    } finally {
+        if (reader != null) {
+            try {
+                reader.close();
+            } catch (Throwable t) {
+                ;
+            }
+            reader = null;
+            stream = null;
+        }
+        if (stream != null) {
+            try {
+                stream.close();
+            } catch (Throwable t) {
+                ;
+            }
+            stream = null;
+        }
     }
-    catch (Exception e) {
-        System.out.println("\n BrowserControl not getting created \n");
-        System.out.println(e.getMessage());
+    if (null != className) {
+        try {
+            Class clazz = classLoader.loadClass(className);
+            instance = (BrowserControlFactoryInterface) (clazz.newInstance());
+        } catch (Exception e) {
+        }
     }
+    return instance;
 }
-
-// ----UNIT_TEST_END

 } // end of class BrowserControlFactory
Index: classes_spec/org/mozilla/webclient/BrowserControlImpl.java
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/classes_spec/org/mozilla/webclient/BrowserControlImpl.java,v
retrieving revision 1.7
diff -u -r1.7 BrowserControlImpl.java
--- classes_spec/org/mozilla/webclient/BrowserControlImpl.java	27 Jul 2001 20:57:52 -0000	1.7
+++ classes_spec/org/mozilla/webclient/BrowserControlImpl.java	6 Sep 2003 06:22:07 -0000
@@ -30,8 +30,8 @@
 import org.mozilla.util.Utilities;


-
-class BrowserControlImpl extends Object implements BrowserControl
+// PENDING(edburns); move this inside impl package
+public class BrowserControlImpl extends Object implements BrowserControl
 {
 //
 // Protected Constants
@@ -145,8 +145,8 @@
 //
 // Class methods
 //
-
-static void appInitialize(String myBrowserType, String verifiedBinDirAbsolutePath) throws Exception
+// PENDING(edburns): make this package private again
+public static void appInitialize(String myBrowserType, String verifiedBinDirAbsolutePath) throws Exception
 {
     browserType = myBrowserType;
     if (null == wrapperFactory) {
@@ -157,7 +157,8 @@
     wrapperFactory.initialize(verifiedBinDirAbsolutePath);
 }

-static void appTerminate() throws Exception
+// PENDING(edburns): make this package private again
+public static void appTerminate() throws Exception
 {
     Assert.assert_it(null != wrapperFactory);

Index: test/automated/src/classes/org/mozilla/webclient/WebclientTestCase.java
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/test/automated/src/classes/org/mozilla/webclient/WebclientTestCase.java,v
retrieving revision 1.1
diff -u -r1.1 WebclientTestCase.java
--- test/automated/src/classes/org/mozilla/webclient/WebclientTestCase.java	1 Oct 2002 00:39:28 -0000	1.1
+++ test/automated/src/classes/org/mozilla/webclient/WebclientTestCase.java	6 Sep 2003 06:22:08 -0000
@@ -133,6 +133,16 @@
 	
 }
 
+protected void verifyBinDirSet()
+{
+    assertTrue("BROWSER_BIN_DIR is not set",
+	       null != System.getProperty("BROWSER_BIN_DIR"));
+}
+
+protected String getBrowserBinDir() {
+    return System.getProperty("BROWSER_BIN_DIR");
+}
+
 /**
 
 * assertTrue that NSPR_LOG_FILE is set.
@@ -162,6 +172,7 @@
     // make sure we have at least PR_LOG_DEBUG set
     verifyLogModuleValueIsAtLeastN(WEBCLIENTSTUB_LOG_MODULE, 4);
     verifyLogModuleValueIsAtLeastN(WEBCLIENT_LOG_MODULE, 4);
+    verifyBinDirSet();
     if (sendOutputToFile()) {
 	verifyOutputFileIsSet();
     }


git-svn-id: svn://10.0.0.236/trunk@146592 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-06 06:26:50 +00:00
dbaron%dbaron.org
cc04f1fff3 Let ComputeHorizontalValue handle unconstrained width, since unconstrained width only means the vertical margin is unknown in some cases. Patch by Mats Palmgren <mats.palmgren@bredband.net>. r+sr=dbaron a=asa b=209066 
git-svn-id: svn://10.0.0.236/trunk@146591 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-06 04:01:33 +00:00
arougthopher%lizardland.net
753c879415 Bug#134837 
-Fixes window focus issues
-Addes new mouse cursors
-All around cleanup

r=sergei_d@fi.tartu.ee
sr=arougthopher


git-svn-id: svn://10.0.0.236/trunk@146589 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 23:59:06 +00:00
igor%mir2.org
91797b35be Replace Context field In REGlobalData by boolean multiline since it is the only information that is needed for matching code from RegExpImpl which was previously accessed through Context. 
git-svn-id: svn://10.0.0.236/trunk@146585 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 21:22:51 +00:00
scott%scott-macgregor.org
7fa2d90e5b Bug #130070 --> Add Mark All Read to the folder pane's context menu. Thanks to Aidas Kasparas for the patch. 
r=neil
sr=mscott
a=asa


git-svn-id: svn://10.0.0.236/trunk@146584 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 21:20:12 +00:00
igor%mir2.org
0dd8664bb1 Fixing regression caused by optimizer changes to address http://bugzilla.mozilla.org/show_bug.cgi?id=198086 : 
Now Script.exec can be called more then once.


git-svn-id: svn://10.0.0.236/trunk@146583 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 21:17:58 +00:00
mkaply%us.ibm.com
fb75f1cb86 Bug #217459 
r/sr=darin, a=asa
Null check for docshell


git-svn-id: svn://10.0.0.236/trunk@146581 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 20:35:04 +00:00
bryner%brianryner.com
3e02507cd1 Workaround for oscillating splitter in mailnews (bug 201379). r=varga, sr=mscott, a=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@146580 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 20:20:40 +00:00
mkaply%us.ibm.com
e1ba2569bf Bug #212821 
r=mkaply, sr=roc, a=mkaply
Allows show all pages in print preview


git-svn-id: svn://10.0.0.236/trunk@146579 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 20:12:32 +00:00
scott%scott-macgregor.org
d46792a502 Bug #216753 --> Message compose should not automatically convert HTML attributes to CSS styles. 
Fix this by setting a flag in editor to not use CSS styles for the background image.

Then back out my fixes in mailnews to work around the inline style editor was giving us. 

With this change, mail compose now handles background images again and they are preserved when you save as draft 
or save as template.

r=neil
sr=bienvenu

a=glazman for the editor change

a=asa for 1.5 final


git-svn-id: svn://10.0.0.236/trunk@146578 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 17:49:36 +00:00
scott%scott-macgregor.org
1c4f87f317 update the version string on the mac 
git-svn-id: svn://10.0.0.236/trunk@146577 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 17:41:53 +00:00
samuel%sieb.net
f10034253e Bug 217776 - Build fails with zip error 
r=rginda
a=asa


git-svn-id: svn://10.0.0.236/trunk@146576 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 17:24:53 +00:00
igor%mir2.org
1e7b554c17 Fixing http://bugzilla.mozilla.org/show_bug.cgi?id=213279 : 
Replacing static caches by global scope based storage.


git-svn-id: svn://10.0.0.236/trunk@146574 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 14:35:09 +00:00
igor%mir2.org
920e2b891c Patch from Nicolas JOUVE to address http://bugzilla.mozilla.org/show_bug.cgi?id=218163 
git-svn-id: svn://10.0.0.236/trunk@146572 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 09:04:36 +00:00
jpierre%netscape.com
31a721d307 Fix for bug 72291 . resolve memory leak on nicknames . r=relyea 
git-svn-id: svn://10.0.0.236/trunk@146567 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-05 00:15:52 +00:00
scott%scott-macgregor.org
5bbf3427cb Bug #218051 --> "Always use this Profile" doesn't work. Thanks to mbr for the patch. 
git-svn-id: svn://10.0.0.236/trunk@146565 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 23:27:33 +00:00
scott%scott-macgregor.org
12e3ef331d change the release notes url 
git-svn-id: svn://10.0.0.236/trunk@146563 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 23:23:31 +00:00
scott%scott-macgregor.org
e2ebcdddd2 bump trunk UA to 0.3a 
git-svn-id: svn://10.0.0.236/trunk@146562 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 23:23:14 +00:00
timeless%mozdev.org
6373885d7f Bug 196658 Error and inconsistency in help_help.html 
patch by magicdice@hotmail.com r=oeschger a=asa


git-svn-id: svn://10.0.0.236/trunk@146561 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 22:32:27 +00:00
timeless%mozdev.org
d08c403c4a Bug 196659 missing word in certs_help.html 
patch by magicdice@hotmail.com r=oeschger a=asa


git-svn-id: svn://10.0.0.236/trunk@146560 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 22:31:56 +00:00
neil%parkwaycc.co.uk
1a792d0598 Bug 218203 Crash when trying to show prompt from onunload p=chpe+mozbugz@stud.uni-saarland.de r=bryner sr=blizzard a=asa 
git-svn-id: svn://10.0.0.236/trunk@146559 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 20:10:45 +00:00
bryner%brianryner.com
1508ed3f85 Notify the treeBoxObject when the row count changes -- should fix assertions when typing in autocomplete. Also, throw in some NS_NOTREACHED statements for functions that should not be getting called on this tree view. 
git-svn-id: svn://10.0.0.236/trunk@146556 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 07:26:30 +00:00
bryner%brianryner.com
075994b6fd Remove inadvertent DOS lineendings (bug 218248) 
git-svn-id: svn://10.0.0.236/trunk@146552 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 03:02:33 +00:00
timeless%mozdev.org
029e5074be Bug 217886 frame structure gets lost in builds since 20030826 
patch by mpconnor@rogers.com r=bz sr=bz a=brendan


git-svn-id: svn://10.0.0.236/trunk@146551 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 02:23:20 +00:00
despotdaemon%netscape.com
b00f5f1a4e Pseudo-automatic update of changes made by myk@mozilla.org. 
git-svn-id: svn://10.0.0.236/trunk@146550 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 01:05:56 +00:00
scott%scott-macgregor.org
319f728db3 win9x part of the fix for bug #172001 
multiple file open can fail for multiple files.

it will still fail, but now it will take a lot more,
since we're using a bigger buffer.

an example: multiple file attach to the compose window.

r/sr/a=sspitzer


git-svn-id: svn://10.0.0.236/trunk@146549 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-04 00:33:48 +00:00
jpierre%netscape.com
7867d7f5ae Remove erroneous assertions 
git-svn-id: svn://10.0.0.236/trunk@146547 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 23:52:01 +00:00
jpierre%netscape.com
cd06748a4f Fix for bug 215152 . Export PK11_FindSlotsByAliases. r=relyea 
git-svn-id: svn://10.0.0.236/trunk@146546 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 22:55:10 +00:00
jpierre%netscape.com
5cc1aecfbe Add PK11_FindSlotsByAliases function . r=relyea 
git-svn-id: svn://10.0.0.236/trunk@146545 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 22:48:20 +00:00
scott%scott-macgregor.org
b75062b971 changing qsrc per jcopetas@askjeeves.com 
not part of the build.


git-svn-id: svn://10.0.0.236/trunk@146544 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 21:43:44 +00:00
neil%parkwaycc.co.uk
df3cc6ae40 Bug 173074 print preview is enabled in the context menu for whitespace p=stevechapel@earthlink.net r=me sr=mscott a=asa 
git-svn-id: svn://10.0.0.236/trunk@146543 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 21:34:24 +00:00
myk%mozilla.org
c64b4b1ac4 Fixed links to take user to default version of bug entry form even if they don't have canconfirm privileges and would thus normally go to the "guided" version of the form. 
----------------------------------------------------------------------


git-svn-id: svn://10.0.0.236/trunk@146542 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 21:09:58 +00:00
mvl%exedo.nl
c03e250d71 Followup to bug 217636, assertion is the wrong way around. Debug only. r=dwitte, sr=darin, a=asa 
git-svn-id: svn://10.0.0.236/trunk@146541 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 20:45:23 +00:00
bienvenu%nventure.com
65b654ec18 fix handling of special folder uri's in case the online server directory is the same as the imap namespace modulo a trailing delimiter, r=ssptizer, sr=mscott, a=sspitzer 214962 
git-svn-id: svn://10.0.0.236/trunk@146539 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 16:28:16 +00:00
mkaply%us.ibm.com
b4b76dd70a a=mkaply - mistake in previous checkin - don't round for printing 
git-svn-id: svn://10.0.0.236/trunk@146538 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 16:21:01 +00:00
bienvenu%nventure.com
95300f4dbf fix handling of online sub-directory specified w/o a trailing delimiter, r=sspitzer, sr=scott, a=sspitzer, 214962 
git-svn-id: svn://10.0.0.236/trunk@146536 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 16:08:23 +00:00
igor%mir2.org
fed3596510 Cosmetics: removal of EOL blanks 
git-svn-id: svn://10.0.0.236/trunk@146535 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 14:26:39 +00:00
brade%comcast.net
6d7cde53e2 remove unused variables, fix typos, code cleanup (r=glazman, sr=tor, a=asa, bug=216054) 
git-svn-id: svn://10.0.0.236/trunk@146534 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 13:58:00 +00:00
brade%comcast.net
a39795413f remove redundant code and unused variables, cleanup (r=glazman, sr=tor, a=asa, bug=216054) 
git-svn-id: svn://10.0.0.236/trunk@146533 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 13:56:21 +00:00
brade%comcast.net
ff0dcd8c0b add helper methods for dealing with pixels; reduce string usage; code cleanup (r=glazman, sr=tor, a=asa, bug=216045) 
git-svn-id: svn://10.0.0.236/trunk@146532 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 13:54:36 +00:00
brade%comcast.net
db8b0f00fb fix typo, removed unused string, code cleanup (r=glazman, sr=tor, a=asa, bug=216045) 
git-svn-id: svn://10.0.0.236/trunk@146531 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 13:49:22 +00:00
igor%mir2.org
8808430336 Work for http://bugzilla.mozilla.org/show_bug.cgi?id=213279 : 
Code for NativeJavaPackage.TopLevelPackage is moved to a separated file NativeJavaTopPackage.java


git-svn-id: svn://10.0.0.236/trunk@146530 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 10:42:36 +00:00
scott%scott-macgregor.org
62bff48d0a fix for bug #172001 
multiple file open can fail for multiple files.

it will still fail, but now it will take a lot more,
since we're using a bigger buffer.

an example:  multiple file attach to the compose window.

see bug #172001 for more details

r=pavlov a=sspitzer


git-svn-id: svn://10.0.0.236/trunk@146529 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 06:24:17 +00:00
scott%scott-macgregor.org
af440d36e0 fix for bug #216581 
Rewrap is broken

thanks to Akkana (akkzilla@shallowsky.com) for the fix

r=brade a=sspitzer for 1.5 final


git-svn-id: svn://10.0.0.236/trunk@146526 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 04:17:45 +00:00
pinkerton%netscape.com
3c58bd256d don't use the capbilities.* prefs to block setting status and window 
resizes as they cause websites to break by throwing unexpectedly.
(bug 216779)


git-svn-id: svn://10.0.0.236/trunk@146525 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 02:51:52 +00:00
brendan%mozilla.org
beaf6245f6 Fix js_FinishTakingSrcNotes edge-case (bug 216320, r=shaver, a=asa). 
git-svn-id: svn://10.0.0.236/trunk@146524 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 02:10:38 +00:00
myk%mozilla.org
48aaae2338 Fix for bug 145588: adds full-text search option for more accurate finding of individual bugs via words that appear in their descriptions/comments/summaries. 
r=bbaetz
a=myk


git-svn-id: svn://10.0.0.236/trunk@146523 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-03 02:03:48 +00:00
mkaply%us.ibm.com
7eaed53c77 #190255 
r=pedemonte, sr=blizzard (platform specific), a=mkaply
OS/2 only - occasional pixel error when scrolling


git-svn-id: svn://10.0.0.236/trunk@146522 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-02 21:22:09 +00:00
mkaply%us.ibm.com
759f5bf65d #217486 
r=pedemonte, sr=blizzard (platform specific), a=mkaply
OS/2 only - rewrite of fullscreen mode code - rather than removing window bits, just size window bigger than desktop


git-svn-id: svn://10.0.0.236/trunk@146521 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-02 20:33:39 +00:00
gerv%gerv.net
a53379a14d Bug 215729 - "Column 'value' cannot be null" trying to upgrade chart data. Patch by gerv; r,a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@146516 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-02 20:13:15 +00:00