60 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
ecf0f13ce8 Bug 565879: Merge ThrowCodeError("action_unrecognized"), ThrowUserError("no_valid_action") and ThrowCodeError("unknown_action")
r=ghendricks a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260347 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-20 15:46:29 +00:00
mkanat%bugzilla.org
a68210b184 Bug 372979: Make voting into an extension
r=mkanat, a=mkanat, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259709 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-15 23:32:10 +00:00
lpsolit%gmail.com
03cbd960b2 Bug 500900: Confirming bugs requires NEW state to exist - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257612 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-01 11:06:37 +00:00
mkanat%bugzilla.org
4088e2081f Bug 219021: Only display email addresses to logged-in users
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@255976 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-29 21:22:39 +00:00
mkanat%bugzilla.org
a055800100 Bug 440612 – Use Bugzilla::Bug->check everywhere instead of ValidateBugID
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@252689 18797224-902f-48f8-a5cc-f745e15eee43
2008-06-29 21:58:05 +00:00
lpsolit%gmail.com
f272dd6c56 Bug 378797: Ability to turn "My votes" page into a bug list - Patch by GavinS <bugzilla@chimpychompy.org> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244814 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-03 11:37:23 +00:00
lpsolit%gmail.com
64903e283d Bug 403834: Replace table locks with database transactions in tokens, votes, and sanitycheck - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@239611 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-18 20:23:54 +00:00
lpsolit%gmail.com
3e660f3c01 Bug 403824: Replace table locks in most Bugzilla files with transactions - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@239400 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-14 22:56:32 +00:00
mkanat%bugzilla.org
d7e641858a Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
lpsolit%gmail.com
43dba5fc79 Bug 383903: Voting for a bug gives a table lock error - Patch by Frédéric Buclin <LpSolit@gmail.com> r=timeless a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@227735 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-10 10:18:42 +00:00
lpsolit%gmail.com
0160b3ee77 Bug 356393: No title is displayed when confirming a bug by popular votes - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@213583 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-13 13:01:57 +00:00
lpsolit%gmail.com
62b9911b91 Bug 351300: votes.cgi crashes if your vote is the one confirming a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r=Colin a=myk
git-svn-id: svn://10.0.0.236/trunk@209168 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-05 12:51:14 +00:00
mkanat%bugzilla.org
4c9d72b0de Bug 341933: Make bug object creation much lighter
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@207650 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-16 21:23:15 +00:00
mkanat%bugzilla.org
150e2acb78 Bug 348464: votes.cgi fails with a taint error
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@207341 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-14 18:07:19 +00:00
mkanat%bugzilla.org
e57a140c9b Bug 348057: Move the checks for bug visibility out of Bugzilla::Bug->new
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@207194 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-11 23:45:08 +00:00
mkanat%bugzilla.org
680d743be8 Bug 173629: Clean up "my" variable scoping issues for mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@201662 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-06 06:12:05 +00:00
lpsolit%gmail.com
fa7cd9ca7b Bug 343699: votes.cgi: Reference found where even-sized list expected - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@201641 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-06 01:49:40 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
mkanat%bugzilla.org
d41b62d88c Bug 342749: Replace Bugzilla::Util's min and max with the List::Util equivalents
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin.ogilvie, r=vladd, a=justdave


git-svn-id: svn://10.0.0.236/trunk@200997 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-27 10:54:05 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
f952ed05cf Bug 304601: Bugzilla::Config's :locations exports need to be in their own module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat for the main patch, r=myk for the patch about CGI.pm a=justdave
Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

Bug 110503 - Eliminate versioncache


git-svn-id: svn://10.0.0.236/trunk@200347 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 20:15:18 +00:00
lpsolit%gmail.com
c3ea909e21 Bug 332522: Remove $::prodmaxvotes - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@198128 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-21 22:15:05 +00:00
lpsolit%gmail.com
c9a524756a Bug 332598: Move ValidatePassword() and DBNameToIdAndCheck() from globals.pl into User.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@196144 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-07 20:13:49 +00:00
lpsolit%gmail.com
968cee22b7 Bug 301020: Remove useless locked tables - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@193321 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 10:27:26 +00:00
mkanat%kerio.com
01baa79a65 Bug 282628: Move OpenStates and IsOpenedState out of globals.pl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=wicked, a=myk


git-svn-id: svn://10.0.0.236/trunk@191842 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-06 21:42:10 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
9b8a7fc2f3 Bug 303700: Eliminate deprecated Bugzilla::DB routines from votes.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@179581 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-02 21:33:36 +00:00
bugreport%peshkin.net
1aa5ece754 Bug 305126: Fix table locks after removal of derive_groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@179306 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 16:04:39 +00:00
lpsolit%gmail.com
8b488047d1 Bug 303366: Possible locking tables conflict when voting for bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@178680 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-23 12:17:17 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
d1fa0293a2 Bug 290513: Move CheckIfVotedConfirmed() out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@172461 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 23:43:00 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
b77c5f0c61 Bug 250440 : when voting for bug, jump down to bug
Patch by GavinS <bugzilla@chimpychompy.org>  r=LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168975 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 15:49:57 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
travis%sedsystems.ca
30dc7b3ab7 Bug 276605 : Ignore vote changes when usevotes = 0
Patch by Frederic Buclin <LpSolit@gmail.com>   r=wurblzap  a=myk


git-svn-id: svn://10.0.0.236/trunk@168400 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-27 19:14:22 +00:00
jocuri%softhome.net
b8a7996c7b Patch for bug 277013: provides a fix for the SQL error that appears when a user's vote confirms a bug; patch by Frédéric Buclin <LpSolit@netscape.net>, r=wurblzap, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167420 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-08 18:24:52 +00:00
jocuri%softhome.net
9ca6784eb7 Patch for bug 273665: Viewing 'My Votes' page should not crash due to lack of SQL table locking; patch by GavinS <bugzilla@chimpychompy.org>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167030 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-25 19:24:32 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
bugreport%peshkin.net
9f826706c4 Bug 253588: Change Bugzilla->user to be usable even for a logged-out user
patch by erik,joel
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160163 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 02:27:26 +00:00
kiko%async.com.br
9ab02843c0 Fix for bug 238869: remove %FORM from votes.cgi. Does just that, free of
XXX comments. r=vladd,justdave; a=justdave.

die %FORM die!


git-svn-id: svn://10.0.0.236/trunk@154810 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 18:34:59 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
justdave%syndicomm.com
e052ecbc87 [SECURITY] Bug 209376: If you know the email address of someone who has voted on a secure bug, you can access the summary of that bug even if you do not have sufficient permissions to view the bug itself.
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave, bbaetz  a= justdave


git-svn-id: svn://10.0.0.236/trunk@148735 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-03 03:20:49 +00:00
timeless%mozdev.org
5486fba3c3 Bug 217242 CheckIfVotedConfirmed tripped Table 'fielddefs' was not locked with LOCK TABLES [for statement ``SELECT fieldid FROM fielddefs WHERE name = 'bug_status''']
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@146504 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-02 01:36:28 +00:00
bbaetz%acm.org
edb59db805 Bug 193575 - Internal server error from votes.cgi
patch by bugzilla@chimpychompy.org (GavinS)
r=bbaetz, a=justdave


git-svn-id: svn://10.0.0.236/trunk@144237 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-28 00:14:56 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00