202 Commits

Author SHA1 Message Date
lpsolit%gmail.com
75838c7dd1 Bug 301764: The file size indicates "0" when editing local attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@185795 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-08 09:14:12 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
bugreport%peshkin.net
d146ce820a Bug 149504 Permit a reference to a URL to be treated as an attachment
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182543 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-19 20:16:15 +00:00
lpsolit%gmail.com
897bd45d39 Bug 302936: Reject the requestee if he cannot access private attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=jouni a=justdave
git-svn-id: svn://10.0.0.236/trunk@182466 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-18 17:48:08 +00:00
bugreport%peshkin.net
7e3f0c05cd Bug 312773 attachment.cgi is broken due to bug 309681
Patch by Frédéric Buclin <LpSolit@gmail.com>
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182438 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-18 03:26:13 +00:00
bugreport%peshkin.net
1d06485337 Bug 309681 Prevent users from adding another user who shouldn't have access to a bug as assignee or CC member
Patch by Gabriel Sales de Oliveira <gabriel@async.com.br>
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182410 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-17 21:19:09 +00:00
lpsolit%gmail.com
56985e1098 Bug 304745: Move GetFieldID() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@179668 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-05 20:41:21 +00:00
bugreport%peshkin.net
1aa5ece754 Bug 305126: Fix table locks after removal of derive_groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@179306 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-30 16:04:39 +00:00
bugreport%peshkin.net
41acde897f Bug 305333: Move attachments.thedata to its own table
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@179112 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-26 23:11:33 +00:00
myk%mozilla.org
60325570ad Fix for bug 292022: accepts multiple requestees in the requestee field for a given flag, and creates multiple requests, one per requestee, so that users can request a flag multiple times simultaneously instead of one at a time; r=joel, a=myk
git-svn-id: svn://10.0.0.236/trunk@178515 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-20 17:02:41 +00:00
lpsolit%gmail.com
12f4168465 Bug 304642: Bugzilla::Flag::GetTarget() should be called internally by Bugzilla::Flag::process() - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@177769 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 18:48:14 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
myk%mozilla.org
9182579d88 Fix for bug 302083: automatically converts BMP files to PNG files to conserve disk space; patch by Greg Hendricks; r=myk, a=myk
git-svn-id: svn://10.0.0.236/trunk@176862 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-30 00:46:40 +00:00
mkanat%kerio.com
60e6184230 Bug 293159: [SECURITY] Anyone can change flags and access bug summaries due to a bad check in Flag::validate() and Flag::modify()
Patch By Frederic Buclin <LpSolit@gmail.com> r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175823 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 05:30:59 +00:00
mkanat%kerio.com
1c86e082c2 Bug 87404: Attachments don't work if you need to use user matching
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175808 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 02:18:22 +00:00
lpsolit%gmail.com
bd81a6f03e Bug 240251: Bug::AppendComment() should receive the user ID as a 2nd parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@175772 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 18:42:09 +00:00
lpsolit%gmail.com
f28fb03f79 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174889 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:46:39 +00:00
lpsolit%gmail.com
66a6bcfa70 Backing out bug 180792. A table is locked as READ while my patch tries to write in it :(
git-svn-id: svn://10.0.0.236/trunk@174886 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 22:20:50 +00:00
lpsolit%gmail.com
2725687439 Bug 180792: Setting and/or updating flags does not update last changed date - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@174871 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 20:04:24 +00:00
lpsolit%gmail.com
9bb519464d Bug 274724: The 'Edit Attachment' link is now available even if a user does not have 'editbugs' privs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=myk
git-svn-id: svn://10.0.0.236/trunk@172798 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-28 02:14:26 +00:00
lpsolit%gmail.com
77277e7fed Bug 238870: remove %FORM from attachment.cgi - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=myk,LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171879 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-08 00:34:39 +00:00
lpsolit%gmail.com
6d78cc1d1b Bug 238878: Make hidden-fields template, User Matching and Flags use direct CGI instead of [% form.foo %] - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:37:56 +00:00
lpsolit%gmail.com
9e44ad4571 Bug 288405: Attachment.cgi fails on Big File attachment inserts - Patch by Marc Schumann <wurblzap@gmail.com> r=joel a=myk
git-svn-id: svn://10.0.0.236/trunk@171612 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 22:23:36 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
lpsolit%gmail.com
1dd5f8d38c Bug 288883: SQL crash when granting/denying a request - Patch by Frederic Buclin <LpSolit@gmail.com> r=joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@171579 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 18:40:59 +00:00
mkanat%kerio.com
48fedcc7c2 Bug 285740: DBD::Pg must have the PG_BYTEA type specified for inserting BLOBs
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=Tomas.Kopal, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170871 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-18 03:23:55 +00:00
travis%sedsystems.ca
d2223e28fc Fix nits on bug 180652 - Frederic Buclin
git-svn-id: svn://10.0.0.236/trunk@170732 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:08:12 +00:00
travis%sedsystems.ca
d21f70cb83 Bug 180652 : Marking an attachment as obsolete should cancel all unfulfilled requests
Patch by Frederic Buclin <LpSolit@gmail.com>  r=myk  a=myk


git-svn-id: svn://10.0.0.236/trunk@170705 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 15:57:19 +00:00
travis%sedsystems.ca
7f544517dc Bug 282574 : use the new "auth_failure" error message for all authentication failures
Patch by Frederic Buclin <LpSolit@gmail.com>   r=travis, wurblzap  a=myk


git-svn-id: svn://10.0.0.236/trunk@170439 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 16:18:03 +00:00
mkanat%kerio.com
3236120a9a Bug 283924: Move ValidateComment out of CGI.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170281 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 13:55:34 +00:00
mkanat%kerio.com
2e945fe489 Bug 280500: Replace "DATE_FORMAT()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@169798 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:37:48 +00:00
bugreport%peshkin.net
42802792c7 Bug 252272: Allow extremely large attachments to be stored locally
r=wurblzap.a=justdave


git-svn-id: svn://10.0.0.236/trunk@169529 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 17:03:10 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
173ffc428b Bug 11901 : Change Bugzilla comments line-wrapping policy
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=gerv,justdave  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169050 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 17:30:20 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
jocuri%softhome.net
490e0c4ac6 Patch for bug 273339: Make attachment.cgi consistent with its activity log timestamps; patch by GavinS <bugzilla@chimpychompy.org>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167073 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-28 23:39:05 +00:00
jake%bugzilla.org
a3ab1de813 Bug 264601 - Bugzilla will now tell a user which field contained an "invalid bug number or alias."
Patch by Frédéric Buclin <LpSolit@netscape.net>
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@166909 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-21 09:04:01 +00:00
kiko%async.com.br
7cde3960a6 Comment-only fix: be honest about where we put that string! r=ssdbot
git-svn-id: svn://10.0.0.236/trunk@164685 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-31 00:50:28 +00:00
jocuri%softhome.net
0df47c2dc9 Patch for bug 254371: include Flag Types in create new attachments form; patch by Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>; r=jouni, a=myk.
git-svn-id: svn://10.0.0.236/trunk@161560 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-31 23:28:10 +00:00
kiko%async.com.br
4cb76eab7f Fix for bug 251911: Silly ThrowUserError bits in attachment.cgi. Fixing
variables missing in some errors raised, and doing bits of $::FORM
cleanup while we're at it. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159848 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-26 01:27:10 +00:00
kiko%async.com.br
6501e204df Fix for bug 252378: Remove $COOKIE from attachment.cgi. r=bugreport,
a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159593 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-21 17:53:34 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00
jouni%heikniemi.net
f50a2c60a3 Bug 223541: Make flags show up correctly in "View all attachments" mode.
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@157124 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-30 15:52:13 +00:00
justdave%bugzilla.org
964fef73ac Bug 204042: taint issues in perl 5.6.0 that were causing an Internal Error to ocurr after adding an attachment.
r= joel, a= justdave


git-svn-id: svn://10.0.0.236/trunk@156202 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-10 16:57:11 +00:00
justdave%syndicomm.com
ba5cacd09f Bug 234540: "Take bug" on create attachment screen missed an API change to BugMail which caused it not to mail the previous bug owner about the change.
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@155563 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-27 03:58:55 +00:00
kiko%async.com.br
9a7a2515e4 Additional fix for bug 87770: attachment.cgi should work with no
parameters. Use <button> tags to allow for localization of the labels.
r=myk, a=myk.

I padded the Edit button with &nbsp;s to ensure it has the same width as
the View button; it may not be kosher but passes as visually agreeable,
at least.


git-svn-id: svn://10.0.0.236/trunk@154822 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 20:31:27 +00:00
jocuri%softhome.net
35e0719e5b Patch for bug 87770: make attachment.cgi work with no parameters; patch by GavinS <bugzilla@chimpychompy.org>; r=kiko; a=myk.
git-svn-id: svn://10.0.0.236/trunk@154676 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-10 15:08:21 +00:00