202 Commits

Author SHA1 Message Date
lpsolit%gmail.com
054bb4fdd3 Bug 472206: [SECURITY] Bugzilla should optionally not allow the user to view possibly harmful attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=justdave a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256027 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 19:12:26 +00:00
lpsolit%gmail.com
0c29cf31b2 Bug 38862: [SECURITY] attachments should be at a different hostname - Patch by Byron Jones <bugzilla@glob.com.au> and Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@256018 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-02 18:26:26 +00:00
lpsolit%gmail.com
edb686a4a0 Bug 467171: Editing attachments doesn't update the Last-Modified bug timestamp - Patch by A.A. Shimono <shimono@mozilla.gr.jp> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255552 18797224-902f-48f8-a5cc-f745e15eee43
2008-12-17 15:07:28 +00:00
mkanat%bugzilla.org
1d59fd5f61 Bug 452734: Remove the keyword chooser, because it's a usability regression
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254284 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-17 23:49:08 +00:00
lpsolit%gmail.com
4b7fde17a0 Bug 388251: Implement 'new Bugzilla::Attachment' - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@254105 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-08 17:13:37 +00:00
lpsolit%gmail.com
8a584b1d0c Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254102 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-08 16:23:46 +00:00
mkanat%bugzilla.org
a055800100 Bug 440612 – Use Bugzilla::Bug->check everywhere instead of ValidateBugID
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@252689 18797224-902f-48f8-a5cc-f745e15eee43
2008-06-29 21:58:05 +00:00
dkl%redhat.com
8270f05627 Bug 422691 – Attachment gets added twice after hitting "Back" and "Refresh"
Patch by David Lawrence <dkl@redhat.com> - r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@252650 18797224-902f-48f8-a5cc-f745e15eee43
2008-06-27 19:56:25 +00:00
lpsolit%gmail.com
80f0e8466a Bug 410902: Some characters are mangled in diff and interdiff modes when viewing patches - Patch by Frédéric Buclin <LpSolit@gmail.com> r=shimono, r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@249044 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-03 16:58:29 +00:00
lpsolit%gmail.com
768540e0ff Bug 414604: After inserting/editing/deleting an attachment, the Keywords field is unavailable - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks r=mkanat a=mkanat
git-svn-id: svn://10.0.0.236/trunk@244925 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-05 11:58:04 +00:00
lpsolit%gmail.com
7b21005ba0 Bug 415155: Remove $cgi from the list of arguments when calling Bugzilla::Flag subroutines - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244865 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-04 13:29:29 +00:00
lpsolit%gmail.com
5c70717ea2 Bug 413772: Eliminate sqlify_criteria() in Bugzilla::Flag and replace match() there with Bugzilla::Object::match() - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@244862 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-04 12:23:48 +00:00
lpsolit%gmail.com
6bbecc2148 Bug 373281: Remove AppendComment entirely in favor of Bugzilla::Bug->add_comment - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@243627 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-20 22:18:56 +00:00
lpsolit%gmail.com
bfff4541d6 Bug 413222: Implement $attachment->remove_from_db - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@243608 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-20 15:03:58 +00:00
mkanat%bugzilla.org
a66f5df45f Bug 408446: Non-text attachments were mangled by "binmode STDOUT, ':utf8'"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@242467 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-06 02:59:42 +00:00
lpsolit%gmail.com
ca154f7412 Bug 99215: Attachments have no midair collision protection - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=justdave a=justdave
git-svn-id: svn://10.0.0.236/trunk@240121 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-29 19:49:16 +00:00
lpsolit%gmail.com
3e660f3c01 Bug 403824: Replace table locks in most Bugzilla files with transactions - Patch by Emmanuel Seyman <eseyman@linagora.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@239400 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-14 22:56:32 +00:00
lpsolit%gmail.com
5f6759ba51 2nd part of bug 398428: After creating or editing an attachment, immediately display the bug it belongs to - Patch by me, a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@239157 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-11 20:20:29 +00:00
mkanat%bugzilla.org
d7e641858a Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
lpsolit%gmail.com
d4fc24bcbd Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237452 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-09 13:06:13 +00:00
lpsolit%gmail.com
ad2fec229d Bug 398739: "Taking a bug" while adding a new attachment locks the bug status forever if the ASSIGNED bug status has been renamed or deleted - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237393 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-08 00:06:33 +00:00
lpsolit%gmail.com
8587c45d3f Bug 398428: After creating or editing an attachment, immediately display the bug it belongs to - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@237191 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-03 17:42:05 +00:00
lpsolit%gmail.com
e0a39066b9 Bug 392175: Move isViewable out of attachment.cgi + some other minor cleanup - Patch by Frédéric Buclin <LpSolit@gmail.com>
git-svn-id: svn://10.0.0.236/trunk@232034 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-14 12:34:51 +00:00
timeless%mozdev.org
e2473ad484 Bug 365472 rename 'token_inexistent' to 'token_does_not_exist' or something
r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@229594 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-10 07:08:12 +00:00
lpsolit%gmail.com
20dacaac32 Bug 376497: validateID() should return an attachment object - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@224148 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-04 15:52:43 +00:00
lpsolit%gmail.com
fe58db6798 Bug 376049: Remove validateCanChangeAttachment() from attachment.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@222662 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-30 22:42:22 +00:00
olav%bkor.dhs.org
1271606ad2 Bug 367649: Deleting an attachment should set isobsolete to 1
Patch by Olav Vitters <olav@bkor.dhs.org> r=LpSolit a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@218717 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-21 15:11:52 +00:00
lpsolit%gmail.com
21b303adf4 Bug 189627: Implement per-product privileges - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@215097 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-10 16:51:30 +00:00
lpsolit%gmail.com
58b1b66792 Bug 281181: [SECURITY] It's way too easy to delete versions/components/milestones etc... - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@213652 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-14 22:02:10 +00:00
lpsolit%gmail.com
c5e32db020 Bug 346086: [SECURITY] attachment.cgi lets you view descriptions of private attachments even when you are not in the insidergroup - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@213649 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-14 21:11:09 +00:00
mkanat%bugzilla.org
38250a7a07 Bug 283582: Remove UserInGroup in favor of Bugzilla->user->in_group
Patch By victory(_RSZ_) <bmo2007@rsz.jp> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@209135 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-04 16:21:49 +00:00
lpsolit%gmail.com
94170053e9 Bug 343809: Merge FlagType::validate() with Flag::validate() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@208300 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-24 15:56:39 +00:00
mkanat%bugzilla.org
e57a140c9b Bug 348057: Move the checks for bug visibility out of Bugzilla::Bug->new
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@207194 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-11 23:45:08 +00:00
lpsolit%gmail.com
21783e31c3 Bug 343814: Move PatchReader specific code into a separate module - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@206508 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-03 19:35:03 +00:00
lpsolit%gmail.com
a229e40757 Bug 343810: Remove Bugzilla::FlagType::get() and implement real flagtype objects - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk
git-svn-id: svn://10.0.0.236/trunk@203590 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-25 00:24:54 +00:00
lpsolit%gmail.com
63b2458081 Bug 174039: Set flags on bug entry - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap r=myk a=myk
git-svn-id: svn://10.0.0.236/trunk@203576 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-24 23:24:34 +00:00
mkanat%bugzilla.org
680d743be8 Bug 173629: Clean up "my" variable scoping issues for mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@201662 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-06 06:12:05 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
9d1b4759b5 Bug 339750: Remove Bugzilla::Flag::GetBug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@200249 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-18 22:46:50 +00:00
lpsolit%gmail.com
68fd3a10ed Bug 5179: Need to be able to put attachment on new bug - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@200220 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-17 23:24:36 +00:00
lpsolit%gmail.com
5e571d4101 Bug 340139: When adding a new attachment, data inserted in the bugs_activity table are quoted - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor, r=ghendricks, r=vladd a=justdave
git-svn-id: svn://10.0.0.236/trunk@198959 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-03 20:06:36 +00:00
lpsolit%gmail.com
80e7a0ca5b Bug 300549: Eliminate deprecated Bugzilla::DB routines from Flag.pm and FlagType.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@196710 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 22:49:14 +00:00
lpsolit%gmail.com
40b049fbee Bug 44595: Implement an interface for administrators to delete attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked, justdave a=justdave
git-svn-id: svn://10.0.0.236/trunk@194526 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-17 20:19:37 +00:00
lpsolit%gmail.com
b440b8e903 Bug 322285: Cancelling a flag should remove it completely from the DB - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@194416 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-14 16:50:47 +00:00
lpsolit%gmail.com
8f4dbde4fa Bug 303688: Eliminate deprecated Bugzilla::DB routines from attachment.cgi - Patch by Greg Hendricks <ghendricks@novell.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@194280 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 23:08:20 +00:00
lpsolit%gmail.com
db3b7de6c0 Bug 332705: Taking a bug when posting a new attachment doesn't update the 'duplicates' table - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@193963 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-09 18:23:42 +00:00
lpsolit%gmail.com
06fdf3e6e8 Bug 284875: Move GetBugLink, GetAttachmentLink, and quoteUrls out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@191255 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-25 23:10:53 +00:00
lpsolit%gmail.com
a7fd9467cb Bug 320997: Taking a bug when posting an attachment doesn't set everconfirmed - Patch by Paul <pdemarco@zoominternet.net> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@186721 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-29 21:11:00 +00:00