Make sure we check signed.applets.codebase_principal_support and special urls before going further.
r=jst sr=bzbarsky a=dbaron
git-svn-id: svn://10.0.0.236/trunk@150007 18797224-902f-48f8-a5cc-f745e15eee43
- The patch destroys the digest context member of the CMSContentInfo.
It calls the previously unused function NSS_CMSDigestContext_Cancel
to destroy the digest context. Eliminates an object reference leak.
Bugscape bug 54208, r=relyea
git-svn-id: svn://10.0.0.236/trunk@150002 18797224-902f-48f8-a5cc-f745e15eee43
NSS_CMSSignedData_Decode_AfterData
- These functions call NSS_CMSDigestContext_FinishMultiple, which
always destroys the digest context, regardless of whether it returns
SECSUccess or SECFailure. So, change these functions to always NULL
out the context pointer regardless of the returned value.
NSS_CMSSignedData_VerifySignerInfo()
- Always call NSS_CMSSignerInfo_Verify() to set the verification status
in the signerinfo object, even if some of the other arguments are NULL,
or other failures have occurred, but avoid NULL pointer dereferences
along the way. Notice that this change is dependent on changes to
NSS_CMSSignerInfo_Verify() (see below.)
NSS_CMSSignedData_SetDigests() - skip over missing digests. Don't fail
the function, and don't crash, if digest pointers are NULL.
Bugscape bug 54208, r=relyea
git-svn-id: svn://10.0.0.236/trunk@150001 18797224-902f-48f8-a5cc-f745e15eee43
NSS_CMSDigestedData_Decode_AfterData
- Since NSS_CMSDigestContext_FinishSingle always destroys the context,
regardless of whether it returns SECSuccess or SECFailure, these
functions have been changed to always NULL out the context pointer
after calling NSS_CMSDigestContext_FinishSingle, regardless of the
outcome.
Bugscape bug 54208, r=relyea
git-svn-id: svn://10.0.0.236/trunk@150000 18797224-902f-48f8-a5cc-f745e15eee43
The relevant fixes for this bug include:
NSS_CMSDigestContext_StartMultiple()
- make sure that cmsdigcx->digcxs and cmsdigcx->digobjs are initialized.
- at the "loser" label, be sure to free the digest context itself.
NSS_CMSDigestContext_Cancel()
- after destroying all the objects, free the arrays of pointers to the
objects, and the digest context itself. Previously these items were
leaked by this function.
NSS_CMSDigestContext_FinishMultiple()
- ensure that this function ALWAYS destroys all the NSS digest objects,
and doesn't stop destroying them if it encounters an error. Note that
this is a newer revision of an older patch for that problem.
- always Free the arrays of pointers used in this object.
NSS_CMSDigestContext_FinishSingle()
- simplify this code.
Bugscape bug 54208, r=relyea
git-svn-id: svn://10.0.0.236/trunk@149999 18797224-902f-48f8-a5cc-f745e15eee43
- This function is changed to explicitly allow some of its input arguments
to be NULL. It will set the verification status in the CMSSignerInfo
object accordingly. Since this is the ONLY function that ever sets the
verification status, it must be able to do so even when problems have
occurred.
- lots of cleanup of this source code.
Bugscape bug 54208, r=relyea
git-svn-id: svn://10.0.0.236/trunk@149998 18797224-902f-48f8-a5cc-f745e15eee43
This gives a useful error message if a helper app could not be found (for another error code)
r=bzbarsky sr=darin a=asa
git-svn-id: svn://10.0.0.236/trunk@149992 18797224-902f-48f8-a5cc-f745e15eee43
Some binary attachments are getting set to quoted printable instead of binary as a content type.
Fix this for now by forcing binary attachments.
git-svn-id: svn://10.0.0.236/trunk@149985 18797224-902f-48f8-a5cc-f745e15eee43
Changed btn1.png for classic and modern from attachment 136243 and 136244
Removed btn1.gif and btnwm1.gif
git-svn-id: svn://10.0.0.236/trunk@149978 18797224-902f-48f8-a5cc-f745e15eee43
